Allow checking for user's roles in ManagerInterface::userHasPermission()

[arogachev]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌

[what-the-diff]

PR Summary

• Refactored Manager.php for improved permission checks

  • The refactoring introduces a new parameter for more fine-grained control over user permissions. Now, the system can also return false when asked if a non-permission item type has an authorization, helping prevent misuse of roles or access checks. This change also simplifies some logic by utilizing item instead of permission, making the code cleaner to understand.

• Adjusted ManagerConfigurationTestTrait.php to support new permission check behaviour

  • Adapted the methods to incorporate the newly created parameter enhancing the testing suite. The createManager method and constructor were updated to accept and pass the new parameter, ensuring that all parts of the software can operate with these updated permissions checks.

• Enhanced ManagerLogicTestTrait.php with additional test method

  • This test method, testUserHasPermissionWithRoleNotAllowed, validates the new feature where permission checks can be limited to only permissions and not roles. The additional test assertion ensures the changes work as expected, adding reliability to the implementation.

• Tuned ManagerConfigurationTestTrait.php for aligned manager creation

  • The createFilledManager method under ManagerConfigurationTestTrait.php got updated to pass the new parameter. This change ensures that even complex managers created during tests are using the updated permissions checks, keeping tests accurate and trustworthy.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (28c9f1e) to head (2637afb).

❗ Current head 2637afb differs from pull request most recent head 529e8a6. Consider uploading reports for the commit 529e8a6 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##              master      #254   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       220       219    -1     
===========================================
  Files             14        13    -1     
  Lines            550       546    -4     
===========================================
- Hits             550       546    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arogachev]

The changes have been synced with main branch.