Skip to content

Do not use storages directly#202

Merged
arogachev merged 2 commits intomasterfrom
no-direct-storage-use
Nov 22, 2023
Merged

Do not use storages directly#202
arogachev merged 2 commits intomasterfrom
no-direct-storage-use

Conversation

@arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

@arogachev arogachev requested a review from a team October 19, 2023 07:57
@arogachev arogachev self-assigned this Oct 19, 2023
@arogachev arogachev added the type:task Task label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8b1ef5d) 100.00% compared to head (c508a18) 98.31%.
Report is 2 commits behind head on master.

❗ Current head c508a18 differs from pull request most recent head bff9c37. Consider uploading reports for the commit bff9c37 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #202      +/-   ##
=============================================
- Coverage     100.00%   98.31%   -1.69%     
- Complexity        98      106       +8     
=============================================
  Files             10       11       +1     
  Lines            288      297       +9     
=============================================
+ Hits             288      292       +4     
- Misses             0        5       +5     
Files Coverage Δ
src/CompositeRule.php 100.00% <100.00%> (ø)
src/Manager.php 99.47% <100.00%> (-0.53%) ⬇️
src/RuleContext.php 60.00% <60.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev merged commit c8d3a09 into master Nov 22, 2023
@arogachev arogachev deleted the no-direct-storage-use branch November 22, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants