Skip to content

Adjust pretty name of closures on PHP 8.4#96

Closed
staabm wants to merge 6 commits intoyiisoft:masterfrom
staabm:patch-1
Closed

Adjust pretty name of closures on PHP 8.4#96
staabm wants to merge 6 commits intoyiisoft:masterfrom
staabm:patch-1

Conversation

@staabm
Copy link

@staabm staabm commented May 25, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

related to php/php-src#13550

see analog symfony change: symfony/symfony#54614

@codecov
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (3215a38) to head (5b700c7).
Report is 8 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master      #96      +/-   ##
=============================================
- Coverage     100.00%   96.17%   -3.83%     
  Complexity        89       89              
=============================================
  Files              3        3              
  Lines            211      209       -2     
=============================================
- Hits             211      201      -10     
- Misses             0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roxblnfk
Copy link
Member

Need to add a test with PHP 8.4

@staabm
Copy link
Author

staabm commented May 25, 2024

@vjik vjik added the status:under development Someone is working on a pull request. label May 25, 2024
@samdark samdark self-requested a review July 7, 2024 07:48
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need test with PHP 8.4

@vjik vjik mentioned this pull request Feb 21, 2025
@vjik
Copy link
Member

vjik commented Mar 13, 2025

Closed in favor #105

@vjik vjik closed this Mar 13, 2025
@staabm staabm deleted the patch-1 branch March 13, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants