-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise up PHP version #64
Conversation
Need a line for CHANGELOG. |
Done |
We can merge both methods to one: public static function lastModifiedTime(string|RecursiveDirectoryIterator ...$directories): ?int Seems, this is will be convient method. |
In current version that helper has php7.4 in composer. Without this i was use union types |
Can raise PHP version to /**
* @param string|RecursiveDirectoryIterator ...$directories
*/
public static function lastModifiedTime(...$directories): ?int |
I think raise version is a better solution, but it must be impemented in assets too. How do you think? |
Yes, it's OK. |
👍 |
That PR is a part of this
RecursiveDirectoryIterator
as argument inFileHelper::lastModifiedTime