Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise up PHP version #64

Merged
merged 9 commits into from
Jul 4, 2022
Merged

Raise up PHP version #64

merged 9 commits into from
Jul 4, 2022

Conversation

Gerych1984
Copy link
Contributor

@Gerych1984 Gerych1984 commented Jun 8, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

That PR is a part of this

  1. Raise php version to ^8.0
  2. Allow RecursiveDirectoryIterator as argument in FileHelper::lastModifiedTime

@samdark
Copy link
Member

samdark commented Jun 20, 2022

Need a line for CHANGELOG.

@Gerych1984
Copy link
Contributor Author

Need a line for CHANGELOG.

Done

@vjik
Copy link
Member

vjik commented Jun 30, 2022

We can merge both methods to one:

public static function lastModifiedTime(string|RecursiveDirectoryIterator ...$directories): ?int

Seems, this is will be convient method.

@Gerych1984
Copy link
Contributor Author

We can merge both methods to one:

public static function lastModifiedTime(string|RecursiveDirectoryIterator ...$directories): ?int

Seems, this is will be convient method.

In current version that helper has php7.4 in composer. Without this i was use union types

@vjik
Copy link
Member

vjik commented Jun 30, 2022

In current version that helper has php7.4 in composer. Without this i was use union types

Can raise PHP version to ^8.0 or use so:

/**
 * @param string|RecursiveDirectoryIterator ...$directories
 */ 
public static function lastModifiedTime(...$directories): ?int

@Gerych1984
Copy link
Contributor Author

Gerych1984 commented Jun 30, 2022

In current version that helper has php7.4 in composer. Without this i was use union types

Can raise PHP version to ^8.0 or use so:

/**
 * @param string|RecursiveDirectoryIterator ...$directories
 */ 
public static function lastModifiedTime(...$directories): ?int

I think raise version is a better solution, but it must be impemented in assets too. How do you think?

@vjik
Copy link
Member

vjik commented Jun 30, 2022

I think raise version is a better solution, but it must be impemented in assets too. How do you think?

Yes, it's OK.

@Gerych1984 Gerych1984 changed the title Separate lastModified and lastModifiedFromIterator Raise up PHP version Jul 1, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/FileHelper.php Show resolved Hide resolved
@samdark samdark merged commit 2dee5da into yiisoft:master Jul 4, 2022
@samdark
Copy link
Member

samdark commented Jul 4, 2022

👍

@samdark samdark added the type:enhancement Enhancement label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants