Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Feb 9, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues yiisoft/app#271

@vjik vjik marked this pull request as ready for review February 9, 2023 10:32
@vjik vjik requested a review from a team February 9, 2023 10:32
@vjik vjik added the status:code review The pull request needs review. label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 78.94% // Head: 79.36% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (dadc58b) compared to base (879e7d1).
Patch has no changes to coverable lines.

❗ Current head dadc58b differs from pull request most recent head 4d5b162. Consider uploading reports for the commit 4d5b162 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     78.94%   79.36%   +0.42%     
  Complexity      160      160              
============================================
  Files            12       12              
  Lines           475      475              
============================================
+ Hits            375      377       +2     
+ Misses          100       98       -2     
Impacted Files Coverage Δ
src/ErrorHandler.php 60.00% <0.00%> (+3.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit 82d94f6 into master Feb 14, 2023
@vjik vjik deleted the adapt-configs branch February 14, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants