Extract response generator from ErrorCatcher middleware#133
Extract response generator from ErrorCatcher middleware#133vjik merged 10 commits intoyiisoft:masterfrom olegbaturin:extract-response-generator
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 78.86% 77.31% -1.56%
- Complexity 170 180 +10
============================================
Files 13 14 +1
Lines 511 551 +40
============================================
+ Hits 403 426 +23
- Misses 108 125 +17 ☔ View full report in Codecov by Sentry. |
|
Good one overall but needs minor adjustments before being merged. |
|
What about "psr/event-dispatcher" dependency? It's absent in the master branch. Should it be added to the composer.json in this pr? |
Not need. |
I've added it to the "require-dev", because it required for tests. |
|
Good refactoring 👍 |
"psr/event-dispatcher" must be in the composer.json "require" section?