Show full argument by click (+bugfix) #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xepozz
changed the title
vjik
requested changes
Jun 29, 2024
Member
vjik
left a comment
vjik
left a comment
There was a problem hiding this comment.
Revert space here:
In released version:
samdark
requested changes
Jun 30, 2024
samdark
reviewed
Jun 30, 2024
| // toggle code block visibility | ||
| callStackItems[i].getElementsByClassName('element-wrap')[0].addEventListener('click', function (event) { | ||
| stackItem.querySelector('.show-arguments-toggle')?.addEventListener('click', function (e) { | ||
| e.stopPropagation() |
Member
There was a problem hiding this comment.
Either let's add ; everywhere or remove it everywhere. I'm for adding it.
Member
Author
There was a problem hiding this comment.
I'll add it in the last PR in the sequence
samdark
approved these changes
Jun 30, 2024
vjik
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed firing
clickevent when selecting text