Add FOR clause for query

[vjik]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	✔️
Fix #813

Related PRs:

• Add FOR clause for query db-sqlite#354

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (c497fa3) to head (0690aee).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #967   +/-   ##
=========================================
  Coverage     99.19%   99.19%           
- Complexity     1600     1611   +11     
=========================================
  Files            98       98           
  Lines          3953     3980   +27     
=========================================
+ Hits           3921     3948   +27     
  Misses           32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Tigrov]

In MSSQL it is deprecated
https://learn.microsoft.com/en-us/sql/odbc/reference/appendixes/processing-select-for-update-statements?view=sql-server-ver16

MSSQL has different lock mechanism
SELECT * FROM table_name WITH (UPDLOCK) WHERE ...
https://learn.microsoft.com/en-us/sql/t-sql/queries/hints-transact-sql-table?view=sql-server-ver16

We can still try SELECT FOR UPDATE while it works

[vjik]

In MSSQL it is deprecated https://learn.microsoft.com/en-us/sql/odbc/reference/appendixes/processing-select-for-update-statements?view=sql-server-ver16
MSSQL has different lock mechanism SELECT * FROM table_name WITH (UPDLOCK) WHERE ... https://learn.microsoft.com/en-us/sql/t-sql/queries/hints-transact-sql-table?view=sql-server-ver16
We can still try SELECT FOR UPDATE while it works

Seems, this is about ODBC Cursor Library only: https://learn.microsoft.com/en-us/sql/odbc/reference/appendixes/appendix-f-odbc-cursor-library?view=sql-server-ver16

MSSQL supports FOR clause, see:

• https://learn.microsoft.com/en-us/sql/t-sql/queries/select-transact-sql?view=sql-server-ver16
• https://learn.microsoft.com/en-us/sql/t-sql/queries/select-for-clause-transact-sql?view=sql-server-ver16

[Tigrov]

MSSQL supports FOR clause, see:

There are only

• FOR BROWSE
• FOR XML
• FOR JSON

But no FOR UPDATE

[vjik]

But no FOR UPDATE

You're right.

Currently SELECT ... FOR UPDATE usage in MSSQL required special settings of connection (docs), right?

May be add "not supported" exception in forUpdate() to mssql?

[Tigrov]

May be add "not supported" exception in forUpdate() to mssql?

Yes, for now can be marked as "not supported".

[vjik]

May be add "not supported" exception in forUpdate() to mssql?

Yes, for now can be marked as "not supported".

forUpdate() method is in Query class. So we can't check it in MSSQL driver code. Maybe keep it as is?

[rustamwin]

👍