Skip to content

Refactor "WITH" #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 27, 2025
Merged

Refactor "WITH" #1082

merged 14 commits into from
Oct 27, 2025
+97 −60

Conversation

@vjik
Copy link
Member

@vjik vjik commented Oct 26, 2025 •
edited
Loading

@vjik vjik mentioned this pull request Oct 26, 2025
Merged
@codecov
Copy link

codecov bot commented Oct 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.52%. Comparing base (d368c95) to head (abb7869).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/QueryBuilder/AbstractDQLQueryBuilder.php 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1082      +/-   ##
============================================
- Coverage     98.54%   98.52%   -0.03%     
- Complexity     1658     1659       +1     
============================================
  Files           118      119       +1     
  Lines          4261     4265       +4     
============================================
+ Hits           4199     4202       +3     
- Misses           62       63       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik mentioned this pull request Oct 26, 2025
Merged
This was referenced Oct 26, 2025
Merged
Merged
Merged
@vjik vjik marked this pull request as ready for review October 26, 2025 15:01
@vjik vjik requested a review from a team October 26, 2025 15:04
@vjik vjik added the status:code review The pull request needs review. label Oct 26, 2025
Tigrov
Tigrov approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs lines to change and upgrade

@vjik vjik requested a review from Tigrov October 27, 2025 07:10
@vjik vjik merged commit 3e017bb into master Oct 27, 2025
68 of 70 checks passed
@vjik vjik deleted the refactor-with branch October 27, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

@Tigrov Tigrov Awaiting requested review from Tigrov

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vjik @samdark @Tigrov