Add autoIncrement in Primary Key.

CHANGELOG.md

@@ -2,8 +2,8 @@
 
 ## 1.0.1 under development
 
-- no changes in this release.
+- Enh #226: Add support for auto increment in primary key column. (@terabytesoftw)
 
 ## 1.0.0 April 12, 2023
 
-- Initial release.
+- Initial release.

README.md

@@ -31,7 +31,7 @@ your Oracle database and perform various database operations as needed.
 
 |  PHP | Oracle Version           |  CI-Actions
 |:----:|:------------------------:|:---:|
-|**8.0 - 8.2**| **11 - 21**|[![build](https://github.com/yiisoft/db-oracle/actions/workflows/build.yml/badge.svg?branch=dev)](https://github.com/yiisoft/db-oracle/actions/workflows/build.yml) [![Mutation testing badge](https://img.shields.io/endpoint?style=flat&url=https%3A%2F%2Fbadge-api.stryker-mutator.io%2Fgithub.com%2Fyiisoft%2Fdb-oracle%2Fmaster)](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/db-oracle/master) [![static analysis](https://github.com/yiisoft/db-oracle/actions/workflows/static.yml/badge.svg?branch=dev)](https://github.com/yiisoft/db-oracle/actions/workflows/static.yml) [![type-coverage](https://shepherd.dev/github/yiisoft/db-oracle/coverage.svg)](https://shepherd.dev/github/yiisoft/db-oracle)
+|**8.0 - 8.2**| **18 - 21**|[![build](https://github.com/yiisoft/db-oracle/actions/workflows/build.yml/badge.svg?branch=dev)](https://github.com/yiisoft/db-oracle/actions/workflows/build.yml) [![Mutation testing badge](https://img.shields.io/endpoint?style=flat&url=https%3A%2F%2Fbadge-api.stryker-mutator.io%2Fgithub.com%2Fyiisoft%2Fdb-oracle%2Fmaster)](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/db-oracle/master) [![static analysis](https://github.com/yiisoft/db-oracle/actions/workflows/static.yml/badge.svg?branch=dev)](https://github.com/yiisoft/db-oracle/actions/workflows/static.yml) [![type-coverage](https://shepherd.dev/github/yiisoft/db-oracle/coverage.svg)](https://shepherd.dev/github/yiisoft/db-oracle)
 
 ## Installation
 

src/QueryBuilder.php

@@ -17,10 +17,10 @@ final class QueryBuilder extends AbstractQueryBuilder
      * @psalm-var string[] $typeMap Mapping from abstract column types (keys) to physical column types (values).
      */
     protected array $typeMap = [
-        SchemaInterface::TYPE_PK => 'NUMBER(10) NOT NULL PRIMARY KEY',
-        SchemaInterface::TYPE_UPK => 'NUMBER(10) UNSIGNED NOT NULL PRIMARY KEY',
-        SchemaInterface::TYPE_BIGPK => 'NUMBER(20) NOT NULL PRIMARY KEY',
-        SchemaInterface::TYPE_UBIGPK => 'NUMBER(20) UNSIGNED NOT NULL PRIMARY KEY',
+        SchemaInterface::TYPE_PK => 'NUMBER(10) GENERATED BY DEFAULT AS IDENTITY NOT NULL PRIMARY KEY',
+        SchemaInterface::TYPE_UPK => 'NUMBER(10) GENERATED BY DEFAULT AS IDENTITY UNSIGNED NOT NULL PRIMARY KEY',
+        SchemaInterface::TYPE_BIGPK => 'NUMBER(20) GENERATED BY DEFAULT AS IDENTITY NOT NULL PRIMARY KEY',
+        SchemaInterface::TYPE_UBIGPK => 'NUMBER(20) GENERATED BY DEFAULT AS IDENTITY UNSIGNED NOT NULL PRIMARY KEY',
         SchemaInterface::TYPE_CHAR => 'CHAR(1)',
         SchemaInterface::TYPE_STRING => 'VARCHAR2(255)',
         SchemaInterface::TYPE_TEXT => 'CLOB',

src/Schema.php

@@ -319,6 +319,7 @@ protected function findColumns(TableSchemaInterface $table): bool
             A.DATA_TYPE,
             A.DATA_PRECISION,
             A.DATA_SCALE,
+            A.IDENTITY_COLUMN,
             (
             CASE A.CHAR_USED WHEN 'C' THEN A.CHAR_LENGTH
                 ELSE A.DATA_LENGTH
@@ -366,6 +367,7 @@ protected function findColumns(TableSchemaInterface $table): bool
              *   data_type: string,
              *   data_precision: string,
              *   data_scale: string,
+             *   identity_column: string,
              *   data_length: string,
              *   nullable: string,
              *   data_default: string|null,
@@ -417,6 +419,7 @@ protected function getTableSequenceName(string $tableName): bool|float|int|strin
      *   data_type: string,
      *   data_precision: string,
      *   data_scale: string,
+     *   identity_column: string,
      *   data_length: string,
      *   nullable: string,
      *   data_default: string|null,
@@ -430,6 +433,7 @@ protected function createColumnSchema(array $column): ColumnSchemaInterface
         $c->allowNull($column['nullable'] === 'Y');
         $c->comment($column['column_comment'] ?? '');
         $c->primaryKey((int) ($column['is_pk'] ?? 0) > 0);
+        $c->autoIncrement($column['identity_column'] === 'YES');
 
         $this->extractColumnType(
             $c,

tests/Provider/SchemaProvider.php

@@ -233,7 +233,7 @@ public static function columns(): array
                         'phpType' => 'integer',
                         'primaryKey' => true,
                         'allowNull' => false,
-                        'autoIncrement' => false,
+                        'autoIncrement' => true,
                         'enumValues' => null,
                         'size' => 22,
                         'precision' => null,

tests/QueryBuilderTest.php

@@ -305,7 +305,7 @@ public function testCreateTable(): void
         $this->assertSame(
             <<<SQL
             CREATE TABLE "test" (
-            \t"id" NUMBER(10) NOT NULL PRIMARY KEY,
+            \t"id" NUMBER(10) GENERATED BY DEFAULT AS IDENTITY NOT NULL PRIMARY KEY,
             \t"name" VARCHAR2(255) NOT NULL,
             \t"email" VARCHAR2(255) NOT NULL,
             \t"status" NUMBER(10) NOT NULL,

tests/Support/Fixture/oci.sql

@@ -191,7 +191,7 @@ CREATE SEQUENCE "bool_values_SEQ";
 
 
 CREATE TABLE "animal" (
-  "id" integer,
+  "id" integer generated by default as identity,
   "type" varchar2(255) not null,
   CONSTRAINT "animal_PK" PRIMARY KEY ("id") ENABLE
 );