Skip to content

Custom serializer#100

Open
Gerych1984 wants to merge 2 commits intoyiisoft:masterfrom
Gerych1984:custom-serializer
Open

Custom serializer#100
Gerych1984 wants to merge 2 commits intoyiisoft:masterfrom
Gerych1984:custom-serializer

Conversation

@Gerych1984
Copy link

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (a43c86e) to head (9233b1d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #100   +/-   ##
=========================================
  Coverage     91.56%   91.56%           
- Complexity       69       70    +1     
=========================================
  Files             1        1           
  Lines           166      166           
=========================================
  Hits            152      152           
  Misses           14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea very much. Please add a line for CHANGELOG.md, tests and docs. Thanks.

"php": "8.1 - 8.5",
"psr/simple-cache": "^2.0 || ^3.0"
"psr/simple-cache": "^2.0 || ^3.0",
"yiisoft/cache": "^3.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not required for this package to function as PSR cache implementation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I don't understand how to throw the interface into the caches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current implementation, your approach is fine.

@samdark
Copy link
Member

samdark commented Jan 25, 2026

Overall approach looks fine. So would you please add tests and a line for a changelog? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants