Perf: Inline getRootValue in getValue for simple array access #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Jul 25, 2025
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the getValue method in ArrayHelper by adding a fast path for simple array access operations. The optimization inlines the common case of retrieving a value from an array using a string or integer key, avoiding the overhead of calling the more complex getRootValue method when dealing with simple key access patterns.
Key changes:
- Adds an early return condition for simple array access using string or integer keys
- Uses
array_key_existsfor existence check followed by direct array access
roxblnfk
reviewed
Jul 25, 2025
|
Need to compare results one more time. |
Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
xepozz
reviewed
Jul 26, 2025
| return $key($array, $default); | ||
| } | ||
|
|
||
| if (is_array($array) && is_scalar($key)) { |
There was a problem hiding this comment.
use common is_array($array) check with the following condition instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.