Fix make codecept build executing build target unintentionally#400
Closed
Fix make codecept build executing build target unintentionally#400
Conversation
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix @yiisoft/app/issues/396
Fix make codecept build executing build target unintentionally
Aug 30, 2025
samdark
requested changes
Aug 30, 2025
|
|
||
| CLI_ARGS := $(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS)) | ||
| $(eval $(CLI_ARGS):;@:) | ||
| $(eval $(filter-out build,$(CLI_ARGS)):;@:) |
| else | ||
| $(DOCKER_COMPOSE_DEV) build $(CLI_ARGS) | ||
| endif | ||
| .PHONY: build |
Author
There was a problem hiding this comment.
Agreed, removed the .PHONY: build declaration. Fixed in commit b840134.
|
|
||
| codecept: ## Run Codeception | ||
| $(DOCKER_COMPOSE_TEST) run --rm app ./vendor/bin/codecept $(CLI_ARGS) | ||
| .PHONY: codecept |
Author
There was a problem hiding this comment.
Correct, removed the .PHONY: codecept declaration. Fixed in commit b840134.
Comment on lines
+99
to
+101
| # Catch-all rule to prevent "No rule to make target" errors | ||
| %: | ||
| @: |
Author
There was a problem hiding this comment.
You're right, the catch-all rule was unnecessary and has been removed. Fixed in commit b840134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes have been reverted as requested by the reviewer.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.