-
-
Notifications
You must be signed in to change notification settings - Fork 880
Don't fallback to parse usual R comments in Quarto #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yihui
added a commit
to yihui/xfun
that referenced
this pull request
Mar 4, 2025
…sing `#|` when `#` is not the comment char of the engine (yihui/knitr#2225), and also add argument `...` to make it possible to not use the yaml package when parsing YAML options (i.e., divide_chunk(use_yaml = FALSE))
#Conflicts: # R/parser.R
yihui
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged after xfun 0.52 is on CRAN.
clrpackages
pushed a commit
to clearlinux-pkgs/R-xfun
that referenced
this pull request
Apr 10, 2025
Yihui Xie (12): start the next version fix a bug in taml_load() that converts chars in arrays to lowercase, and also allow single quotes in char values in arrays add an argument `strict` divide_chunk() to disallow falling back to using `#|` when `#` is not the comment char of the engine (yihui/knitr#2225), and also add argument `...` to make it possible to not use the yaml package when parsing YAML options (i.e., divide_chunk(use_yaml = FALSE)) a new function url_destination() to get destination of redirected URLs deprecate `xfun::attr()` in favor of `xfun::attr2()` to avoid masking `base::attr()` (#96) a simple implementation of LCG (#101) close #100: demote cache_rds() and promote cache_exec() close #99: add an argument `date` to `pkg_bib()` to optionally include the date of retrieval in the bib entries bye, solaris remove unused add_border() (it was written primarily for me to add border to raster images to be included in LaTeX, but I no longer use LaTeX now, and adding borders to images via CSS is trivially simple) leave out renv and rmarkdown in Suggests CRAN release v0.52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to discussion in quarto-dev/quarto-cli#4306
Making this draft PR to test a scenario and discuss. This is WIP
Regarding second commit, if we don't error but just don't fallback we would get this behavior with an obscure error due to in chunk content not being parsed as option