Skip to content

Commit

Permalink
Fix formatting numbers in concat node (software-mansion#720)
Browse files Browse the repository at this point in the history
It turned out that IOS doesn't take locale into consideration when formatting NSNumber, so
this commit fixes that on android
  • Loading branch information
jakub-gonet authored Apr 8, 2020
1 parent 66c0e08 commit cec00c7
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
package com.swmansion.reanimated.nodes;

import java.text.NumberFormat;
import java.util.Locale;

import com.facebook.react.bridge.ReadableMap;
import com.swmansion.reanimated.NodesManager;
import com.swmansion.reanimated.Utils;

public class ConcatNode extends Node {
private final int[] mInputIDs;
private final static NumberFormat sFormatter = NumberFormat.getInstance();
private final static NumberFormat sFormatter = NumberFormat.getInstance(Locale.ENGLISH);
static {
sFormatter.setMinimumFractionDigits(0);
sFormatter.setGroupingUsed(false);
}

public ConcatNode(int nodeID, ReadableMap config, NodesManager nodesManager) {
Expand Down

0 comments on commit cec00c7

Please sign in to comment.