This repository was archived by the owner on Apr 4, 2019. It is now read-only.
Change XMLHttpRequest error handling #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Listen for 'load' event instead of 'readystatechange' because the later can be triggered along with the 'error' event. - Check the response status code, and invoke the callback with an error argument when it is not in the 20x range.
|
So, this avoids the |
|
@cristiandouce yes, and it will also invoke the callback with an error argument when the response doesn't succeed, for instance when a 404 is returned. |
| if (4 == req.readyState) return fn(null, req); | ||
| // sometimes IE returns 1223 when it should be 204 | ||
| // see http://stackoverflow.com/questions/10046972/msie-returns-status-code-of-1223-for-ajax-request | ||
| /^(20\d|1223)$/.test(req.status) ? fn(null, req) : fn(req); |
There was a problem hiding this comment.
Shouldn't the falsey case here create an error to bubble up?
- Rename error.evt to error.event for the network error case. - Pass the request as the second argument instead of as an event property for the unsuccessful request case.
|
@gjohnson any chance on get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
later can be triggered along with the 'error' event.
error argument when it is not in the 20x range.