fix: extract pid from pid column that sometimes contain process name #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Find by port doesn't work on some MacOS devices because the pid column from
netstatcontainedprocessname:pidwhereas the code was expecting just pid, which returns aNaNwhen run throughparseInt(...)I think it's the cause of issue 84.
Proposed change
Try to extract pid from processname:pid using a RegExp capturing group matching decimals
:dand if present, parse into an integer, otherwise, use the cell as is.Also added a check to only resolve the promise if the parsed process is a number, and reject otherwise.