Add httplib::Error to std::string function #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirose
reviewed
Jul 17, 2021
httplib.h
Outdated
| case Error::UnsupportedMultipartBoundaryChars: | ||
| return "UnsupportedMultipartBoundaryChars"; | ||
| case Error::Compression: return "Compression"; | ||
| case Error::Unknown: break; |
There was a problem hiding this comment.
Can you adjust it like this?
case Error::Unknown: return "Unknown";
default: break;
}
return "Invalid";
}
|
@gjasny, please see my review. Also it seems like the unit tests on GitHub Actions failed... |
|
Thanks for the corrections! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #978