Added MACRO for server_certificate_verification #674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I have a request (made with universal interface httplib::Client) which redirects (set_follow_location) from HTTP to HTTPS and I had server_certificate_verification_ set to false, the redirection won't copy my server_certificate_verification_ setting and will make an erroneous request. This solution allows me to keep server_certificate_verification configuration_ = false for my whole code and surrounds my problem. Also, setting server_certificate_verification_ in the universal interface won't have effect (before it had been redirected from HTTP to HTTPS) and SSLClient instance had been created.
|
@gtnardy, thanks for the pull request. It seems "the redirection won't copy my server_certificate_verification_ setting" is a bug. I am thinking to fix the bug instead of introducing |
|
@gtnardy, could you test with the latest httplib.h? It now copies server_certificate_verification_ setting properly. Thanks for your help! |
|
Works like a charm! Thank you! |
|
@gtnardy, thanks for testing it! |
omjego
pushed a commit
to omjego/cpp-httplib
that referenced
this pull request
Oct 2, 2020
yhirose
added a commit
that referenced
this pull request
Oct 2, 2020
* Fix memory leak due caused due to X509_STORE * Add test for repro and address sanitizer to compiler flags * Add comment * Sync * Associate ca_store with ssl context within set_ca_cert_store() * Split SlowPost test * Fix #674 Co-authored-by: yhirose <yuji.hirose.bug@gmail.com>
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
* Fix memory leak due caused due to X509_STORE * Add test for repro and address sanitizer to compiler flags * Add comment * Sync * Associate ca_store with ssl context within set_ca_cert_store() * Split SlowPost test * Fix yhirose#674 Co-authored-by: yhirose <yuji.hirose.bug@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have a request (made with universal interface httplib::Client) which redirects (set_follow_location) from HTTP to HTTPS and I had server_certificate_verification_ set to false, the redirection won't copy my server_certificate_verification_ setting and will make an erroneous request.
This solution allows me to keep server_certificate_verification configuration_ = false for my whole code and surrounds my problem.
Also, setting server_certificate_verification_ in the universal interface won't have effect (before it had been redirected from HTTP to HTTPS) and SSLClient instance had been created.