Don't exit if accept fails due to no more file descriptors #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ha11owed, thanks for your fine contribution! |
|
thanks! this may help reduce chance of #115 recurring |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Don't exit if accept fails due to no more file descriptors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A burst of connections that causes the maximum number of file descriptors to be reached will cause the server to stop.
Instead of stopping, the server could retry after a short timeout (the pull request). More complex mechanisms could also be implemented.
Steps to simulate the problem:
for example by calling "ab -r -n 90000 -c 1000 http://localhost:8888/index.html" in two separate processes (terminals).