Fix select() return code for fd >= 1024 #1757

jfsimoneau · 2024-01-12T21:39:23Z

I noticed all callers look for errors in negative numbers, but these code paths returned 1 instead of -1.

yhirose · 2024-01-15T13:27:41Z

@jfsimoneau thanks for catching the bug!

(cherry picked from commit af2928d)

Fix select() return code for fd >= 1024

89852fc

yhirose merged commit af2928d into yhirose:master Jan 15, 2024
4 checks passed

jfsimoneau deleted the fix-select-corruption branch January 15, 2024 14:43

zhaokeli pushed a commit to zhaokeli/cpp-httplib that referenced this pull request Oct 10, 2024

Fix select() return code for fd >= 1024 (yhirose#1757)

bd7200b

(cherry picked from commit af2928d)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix select() return code for fd >= 1024 #1757

Fix select() return code for fd >= 1024 #1757

jfsimoneau commented Jan 12, 2024

yhirose commented Jan 15, 2024

Fix select() return code for fd >= 1024 #1757

Fix select() return code for fd >= 1024 #1757

Conversation

jfsimoneau commented Jan 12, 2024

yhirose commented Jan 15, 2024