Skip to content

Conversation

omaralvarez
Copy link
Contributor

Added modern CMake support to have a standard way of using the library.

@yhirose
Copy link
Owner

yhirose commented Jun 18, 2019

@omaralvarez, thank you for the quick response! I just noticed that httplib.h is now moved to include directory that breaks all the project files (Makefile and *.vcxproj files) in example directory. Is it required to have include directory for the Conan support? I would like to keep httplib.h right under the root directory if possible, because some of my other git projects contains 'cpp-httplib' via git-submodule and depend on the structure. So I have to fix them as well...

@omaralvarez
Copy link
Contributor Author

It has to do with CMake, I will try to find a solution. But the standard way of doing header only in CMake is that one. I can fix the examples, sorry for not noticing. I'll write here with whatever I find.

@yhirose
Copy link
Owner

yhirose commented Jun 20, 2019

@omaralvarez, here is another example (Chromium Crashpad) that depends on the structure in addition to my personal projects.

https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/third_party/crashpad/crashpad/util/net/http_transport_test_server.cc#L42

As you can see, once httplib.h moves into include directory, the code has to be fixed to point to the new location.

@omaralvarez
Copy link
Contributor Author

Everything is ready, I don't know why the appveyor test failed. Right now the file hierarchy is the same as before, so nothing should break.

@yhirose
Copy link
Owner

yhirose commented Jun 21, 2019

@omaralvarez, thanks for the update. I kicked the AppVeyor test again, and it succeeded this time. Thanks for your great contribution!

@yhirose yhirose merged commit 2f84790 into yhirose:master Jun 21, 2019
@omaralvarez
Copy link
Contributor Author

@yhirose No problem, thanks to you for this awesome library!

ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants