Skip to content

Conversation

@stingray-11
Copy link
Contributor

This prevents compile warnings within cpp-httplib from showing up in an end user's build.

#1426

@yhirose
Copy link
Owner

yhirose commented Nov 20, 2022

@sum01 do you have any comment on this pull request? Thanks!

@sum01
Copy link
Contributor

sum01 commented Nov 20, 2022

I've never actually seen SYSTEM used, so I wasn't sure of its purpose.

Looking it up, it doesn't seem like it really applies to this project, but maybe I'm wrong? To me, it seems like SYSTEM is meant for external includes, not internal ones. @stingray-11

@stingray-11
Copy link
Contributor Author

stingray-11 commented Nov 21, 2022

It is for external includes, but this project itself is "external" for other projects that use it. Other projects might want to be able to enable extra compiler warnings that httplib does not yet pass, and use -Werror. Since httplib is a library I would guess this is the usual case.

I cannot find the Stack overflow post I was looking at before but this one on the cmake forum says "CMake expects the library author not the consumer to set the which include directories should be considered SYSTEM".

@sum01
Copy link
Contributor

sum01 commented Nov 24, 2022

I guess that makes sense. Weird I've not seen others using it before though.

@yhirose yhirose merged commit e7eadc3 into yhirose:master Nov 25, 2022
@yhirose
Copy link
Owner

yhirose commented Nov 25, 2022

Thanks for the contribution!

ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants