Skip to content

Windows Crypto libs linking #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Windows Crypto libs linking #1254

merged 1 commit into from
Apr 21, 2022

Conversation

mylogin
Copy link
Contributor

@mylogin mylogin commented Apr 19, 2022

No description provided.

@mylogin mylogin changed the title Link Windows crypto libs only when CPPHTTPLIB_OPENSSL_SUPPORT is set Windows Crypto libs linking Apr 19, 2022
@yhirose
Copy link
Owner

yhirose commented Apr 19, 2022

@mylogin, the changes in Makefile are ok, but I don't think the changes in httplib.h are not necessary. Please let me know why you modified httplib.h.

@mylogin
Copy link
Contributor Author

mylogin commented Apr 19, 2022

In case MSVC, libraries (crypt32.lib, cryptui.lib) are always linked, regardless of the set macro CPPHTTPLIB_OPENSSL_SUPPORT, this is not necessary if the macro is not set

@yhirose
Copy link
Owner

yhirose commented Apr 19, 2022

@mylogin, thanks for the answer. It's a good improvement.

Another thing that I notice is that LIBS includes not only linker options, but also compiler related options such as -D and -I which don't make sense to me. Since I don't need Windows support in Makefile, could you revert the changes in Makefile?

@mylogin
Copy link
Contributor Author

mylogin commented Apr 20, 2022

git revert performed or better to do a reset last commits?

@yhirose
Copy link
Owner

yhirose commented Apr 20, 2022

@mylogin, you are right. Actually reset is better for keeping the git history clean. Thanks!

@yhirose yhirose merged commit 696239d into yhirose:master Apr 21, 2022
@yhirose
Copy link
Owner

yhirose commented Apr 21, 2022

Thanks for your fine contribution!

ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants