support custom ssl ctx configuration for SSLServer #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirose
force-pushed
the
master
branch
2 times, most recently
from
a9aceab to
c384be0
Compare
|
@CarlosLeeGit, looks good to me. Could you make some adjustments according to my comment above? Thanks! |
|
@yhirose git rebase performed. anything else needed? by the way, could you please tell me the time for next version. Thanks! |
|
@CarlosLeeGit, could you make three adjustments that I mentioned in my review? |
|
@yhirose sorry, i did not find the reviews since you mentioned first. am i missing something? |
yhirose
reviewed
Oct 15, 2021
|
@CarlosLeeGit, sorry that I didn't submit my review... Now you see them. :) |
|
@yhirose i will use cpp-httlib in our project. so i want to known the release plan for next version. could i be informed. :) |
|
The fix is in v0.9.7. Thanks for your contribution! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some conditions, users need to set custom options for ssl_ctx to meet security requirements. Therefore, a constructor is added to SSLServer to support users to customize ssl_ctx during SSLServer construction.