Warning: bufSize is not used

[wichtounet]

Hi,

I just starting trying your library and noticed a warning:

cpp-httplib/httplib.h:256:54: warning: unused parameter ‘bufsiz’ [-Wunused-parameter]
inline bool socket_gets(Stream& strm, char* buf, int bufsiz)

Here

I could ignore it, but since it's a buffer size, wouldn't that be a bug and the bufsize should be used to prevent buffer overflow, no ?

Thanks

Baptiste

[yhirose]

@wichtounet, thanks for the report. It's definitely a dangerous problem. I'll take a look at it.

[wichtounet]

@yhirose Thanks for the fix!

Just a side note, now there are warnings about unsigned comparisons with signed, you can just set the bufSize parameter to unsigned int (or size_t) to silence them.

[yhirose]

@wichtounet, thanks! I fixed them.

[wichtounet]

@yhirose Perfect, thanks :)