Cast ai_addrlen to to int on _WIN32

[DJm00n]

I have solution configured with warning treated as error on Win32/MSVS2017 and have a warning that prevents me to build:

httplib.h(1755): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Please add #ifdef _WIN32 and static_cast<int>(ai.ai_addrlen) here:

cpp-httplib/httplib.h

Line 1755 in e7e9ec6

if (::bind(sock, ai.ai_addr, ai.ai_addrlen)) {

and here:

cpp-httplib/httplib.h

Line 2002 in e7e9ec6

auto ret = connect(sock, ai.ai_addr, ai.ai_addrlen);

Also maybe add global namespace prefix :: to be holistic. Maybe in other places too.

Thank you for a good lib.

[yhirose]

@DJm00n, thanks for the report. I tried to compile with my Visual Studio 2017 with Win32 and x64. But, I only got the warnings on x64:

Win32

1>d:\projects\cpp-httplib\httplib.h(488): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(489): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(505): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data

x64

1>d:\projects\cpp-httplib\test\gtest\gtest.h(15364): note: see reference to class template instantiation 'testing::internal::CartesianProductHolder10<Generator1,Generator2,Generator3,Generator4,Generator5,Generator6,Generator7,Generator8,Generator9,Generator10>' being compiled
1>d:\projects\cpp-httplib\httplib.h(488): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(489): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(491): warning C4244: 'argument': conversion from 'socket_t' to 'int', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(505): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(507): warning C4244: 'argument': conversion from 'socket_t' to 'int', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(1473): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(1478): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(1755): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
1>d:\projects\cpp-httplib\httplib.h(2002): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

How did you get the warnings on Win32? Thanks for your assistance.

[DJm00n]

Yeah, your right I found additional #pragma warning(disable: 4244 4702) in my code.

It will be great if you fix that warnings in upstream.

[yhirose]

I fixed the problem. Thanks for your contribution!