fix: desca[e and removeQuotes did not worked together right

yhdgms1 · Mar 7, 2022 · 6d5ee24 · 6d5ee24
1 parent 5fe9201
commit 6d5ee24
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "description": "Use SVG foreignObject to render images of HTML content",
   "author": "Artem Schukin",
   "license": "MIT",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "type": "module",
   "homepage": "https://github.com/Artemis69/svg-foreignobject-screenshot",
   "repository": {

diff --git a/src/index.ts b/src/index.ts
@@ -1,4 +1,4 @@
-import { getImageUrlsFromHtml, getUrlsFromCss, descape } from './lib'
+import { getImageUrlsFromHtml, getUrlsFromCss, descape, removeQuotes } from './lib'
 import { Options, HookName, HookParameter, BuildSvgDataURI } from './types'
 export { fetcher } from './fetcher'
 
@@ -12,7 +12,7 @@ const useFetcher = async (resources: string[], fetcher: Options['fetcher']) => {
   const results = [] as Array<[string, string]>
 
   for (const resource of resources) {
-    const result = await fetcher(descape(resource))
+    const result = await fetcher(removeQuotes(descape(resource)))
     results.push([resource, result])
   }
 

diff --git a/tests/main.ts b/tests/main.ts
@@ -101,4 +101,8 @@ test('isDataUrl', () => {
   assert.is(isDataUrl('#path'), true)
 })
 
+test('descape and removeQuotes combined', () => {
+  assert.is(removeQuotes(descape('&quot;stars.jpg&quot;')), 'stars.jpg')
+})
+
 test.run()