Add AppImageBuilder #80
Add version labels to generated artifacts
Add version, arch and os labels to generated artifacts. Remove now unneeded VERSION file.
- Loading branch information
commit 2a8ec5e27a30afb615ef0b11f23c1bc1f9129bc7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,10 @@ env: | |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-22.04] | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
|
|
@@ -30,22 +33,25 @@ jobs: | |
|
|
||
| - name: Save version file | ||
| run: | | ||
| VERSION=$(./mlnet -v 2>&1 | sed -ne "1s#^.*Starting MLDonkey \([^ ]\+\) .*#\1#p") | ||
|
There was a problem hiding this comment. there should be better way to get version without running the binary. Worst case can grep configure log, or actually this : see ocaml/ocaml#13637 for why less ugly methods don't work |
||
| { | ||
| echo "APP_VERSION=$VERSION" | ||
| echo "HOST_TYPE=$HOSTTYPE" | ||
| echo "OS_TYPE=${{matrix.os}}" | ||
| } | tee -a $GITHUB_ENV | ||
|
|
||
| - name: Upload mlnet and mlgui binaries | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: mlnet-and-mlgui-${{env.APP_VERSION}}-${{env.HOST_TYPE}}-${{env.OS_TYPE}} | ||
| path: | | ||
| mlnet | ||
| mlgui | ||
|
|
||
| - name: Upload utils | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: mldonkey-utils-${{env.APP_VERSION}}-${{env.HOST_TYPE}}-${{env.OS_TYPE}} | ||
| path: | | ||
| bt_dht_node | ||
| copysources | ||
|
|
@@ -54,19 +60,22 @@ jobs: | |
| mld_hash | ||
| subconv | ||
| svg_converter | ||
| if-no-files-found: warn | ||
|
|
||
| - name: Upload mlnet+gui binary | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: mlnet+gui-${{env.APP_VERSION}}-${{env.HOST_TYPE}}-${{env.OS_TYPE}} | ||
| path: mlnet+gui | ||
| if-no-files-found: warn | ||
|
|
||
| outputs: | ||
| APP_VERSION: ${{env.APP_VERSION}} | ||
| HOST_TYPE: ${{env.HOST_TYPE}} | ||
| OS_TYPE: ${{env.OS_TYPE}} | ||
|
|
||
| appimage: | ||
| if: ${{ needs.build.outputs.OS_TYPE == 'ubuntu-22.04' }} | ||
| needs: build | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
|
|
@@ -76,7 +85,7 @@ jobs: | |
| - name: Download mlnet+gui binary | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: mlnet+gui-${{needs.build.outputs.APP_VERSION}}-${{needs.build.outputs.HOST_TYPE}}-${{needs.build.outputs.OS_TYPE}} | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo apt-get install -y --no-install-recommends libfuse2 | ||
|
|
@@ -93,7 +102,7 @@ jobs: | |
| - name: Build AppImage | ||
| run: | | ||
| # Get application version | ||
| APP_VERSION="${{needs.build.outputs.APP_VERSION}}" | ||
| echo "APP_VERSION=$APP_VERSION" | ||
| export APP_VERSION | ||
| # Download appimage-builder | ||
|
|
@@ -111,6 +120,6 @@ jobs: | |
| - name: Upload AppImage | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: mldonkey-${{needs.build.outputs.APP_VERSION}}-${{needs.build.outputs.HOST_TYPE}}.AppImage | ||
| path: mldonkey-*.AppImage | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think ideally this build part of pipeline should be move to main pipeline, and then here keep only appimage (and use artifacts produced by main build pipeline)