This repository was archived by the owner on May 18, 2024. It is now read-only.
One to many item keys contains duplicates #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 8, 2019 09:19
1) uniqueness=False You can repeat a key in a relationship 2) uniqueness='throws' If a key is repeated an exception is raised 3) uniqueness='clean' Duplicated keys will be cleaned, for example if your keys are [1,2,1], only [1,2] will be serialized
|
hi @yfilali any news on this? |
|
Hi @petecocoon, Thanks for this. The changes look good to me, but my first instinct would have been to not allow duplicates at all and simply de-dupe on the fly which I think makes intuitive sense. I am ok with the behavior you implemented as long as the default is uniqueness='clean'. Any chance you have time to add a blurb to the readme about this? maybe below Limitations as a new section? If not, I'll try to find some time this weekend to go through it in more detail and document before merging it in. Thanks a bunch for the contrib! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yfilali
I have made some enhancements to OneToMany serialize and deserialize.
before this modification save a relationship with the same key duplicated were allowed but at resolve() time boto3 will raise an error with "Provided list of item keys contains duplicates"
see commit #64235f9c5731d5b5a1d836f32d422fb052586cca
I've added the uniqueness parameter to OneToMany constructor
if is not set or is set to False if you set a duplicated item in a relation nothing is done
if you set uniqueness='throws' an exception will be raised.
if you set uniqueness='clean' the keys in relation will be deduplicated
Feel free to modify or makes some changes