Skip to content

Conversation

@asanehisa
Copy link
Contributor

@asanehisa asanehisa commented Jan 23, 2026

live site: https://www.yext.com/s/4412098/yextsites/162230/pagesets

Confirmed english paths all looked correct for each pageset and links on Directory / Locator cards.
Confirmed spanish paths also looked correct for each pageset and links links on Directory / Locator cards.

@asanehisa asanehisa added the create-dev-release Triggers dev release workflow label Jan 23, 2026
@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 23, 2026

commit: 7619c7d

@asanehisa asanehisa marked this pull request as ready for review January 26, 2026 19:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

Walkthrough

This change refactors the path resolution logic in the directory and locator template files. The getPath function signature in both files is updated to accept a relativePrefixToRoot parameter, and the implementation is changed to delegate path resolution to a centralized resolveUrlTemplate utility function instead of constructing paths directly from document slug, locale, and ID properties. Corresponding import statements are updated to remove normalizeSlug and add resolveUrlTemplate.

Possibly related PRs

Suggested reviewers

  • colton-demetriou
  • mkilpatrick
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title is vague and generic, using 'adjust' without specifying what aspect of getPath was modified or why. Consider a more descriptive title like 'refactor: replace slug-based path resolution with URL template resolver in templates' to clarify the substantive change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description documents testing confirmation for English and Spanish paths on a live site, which directly relates to the path resolution changes in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asanehisa asanehisa merged commit bcfec3d into main Jan 26, 2026
18 checks passed
@asanehisa asanehisa deleted the adjust-templates branch January 26, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-dev-release Triggers dev release workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants