feat: renamed media orientation, fixed truncate in event section #971
Conversation
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
WalkthroughThe PR makes two changes: it adjusts EventCard.tsx so DescriptionSlot truncation treats undefined as truncating by using a Sequence Diagram(s)(omitted) Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-12-23T16:36:42.670ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In
@packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx:
- Line 439: Inconsistent handling of the truncateDescription default causes
differing behavior; update the earlier conditional that checks
data.props.styles.truncateDescription (the one currently treating undefined as
falsy) to the same pattern used elsewhere (data.props.styles.truncateDescription
!== false) so both code paths compute shouldTruncate the same way and the
DescriptionSlot renders consistently.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsxpackages/visual-editor/src/components/pageSections/PromoSection.tsx
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: benlife5
Repo: yext/visual-editor PR: 958
File: packages/visual-editor/src/components/pageSections/heroVariants/CompactHero.tsx:38-41
Timestamp: 2025-12-23T16:30:55.497Z
Learning: In CompactHero and CompactPromo components, duplicate IDs on image elements are intentional: conditional visibility classes (hidden/sm:block/sm:hidden) ensure only one image renders at a time based on responsive breakpoints and desktopImagePosition/mobileImagePosition settings.
🧬 Code graph analysis (1)
packages/visual-editor/src/components/pageSections/PromoSection.tsx (2)
packages/visual-editor/src/editor/YextField.tsx (1)
YextField(188-327)packages/visual-editor/src/editor/index.ts (1)
YextField(15-15)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call_unit_test / unit_tests (20.x)
- GitHub Check: call_unit_test / unit_tests (24.x)
- GitHub Check: call_unit_test / unit_tests (22.x)
- GitHub Check: semgrep/ci
🔇 Additional comments (1)
packages/visual-editor/src/components/pageSections/PromoSection.tsx (1)
133-149: LGTM! Clear label improvement.The field label change from "Media Orientation" to "Media Position" improves clarity for users. The underlying property name and functionality remain unchanged, making this a safe UX enhancement.
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @packages/visual-editor/locales/zh-TW/visual-editor.json:
- Line 290: Update the localization value for the "mediaPosition" key: replace
the current string "媒體立場" with "媒體位置" so the zh-TW entry for mediaPosition
matches the intended spatial/layout meaning used in other locales.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (25)
packages/visual-editor/locales/cs/visual-editor.jsonpackages/visual-editor/locales/da/visual-editor.jsonpackages/visual-editor/locales/de/visual-editor.jsonpackages/visual-editor/locales/en-GB/visual-editor.jsonpackages/visual-editor/locales/en/visual-editor.jsonpackages/visual-editor/locales/es/visual-editor.jsonpackages/visual-editor/locales/et/visual-editor.jsonpackages/visual-editor/locales/fi/visual-editor.jsonpackages/visual-editor/locales/fr/visual-editor.jsonpackages/visual-editor/locales/hr/visual-editor.jsonpackages/visual-editor/locales/hu/visual-editor.jsonpackages/visual-editor/locales/it/visual-editor.jsonpackages/visual-editor/locales/ja/visual-editor.jsonpackages/visual-editor/locales/lt/visual-editor.jsonpackages/visual-editor/locales/lv/visual-editor.jsonpackages/visual-editor/locales/nb/visual-editor.jsonpackages/visual-editor/locales/nl/visual-editor.jsonpackages/visual-editor/locales/pl/visual-editor.jsonpackages/visual-editor/locales/pt/visual-editor.jsonpackages/visual-editor/locales/ro/visual-editor.jsonpackages/visual-editor/locales/sk/visual-editor.jsonpackages/visual-editor/locales/sv/visual-editor.jsonpackages/visual-editor/locales/tr/visual-editor.jsonpackages/visual-editor/locales/zh-TW/visual-editor.jsonpackages/visual-editor/locales/zh/visual-editor.json
✅ Files skipped from review due to trivial changes (1)
- packages/visual-editor/locales/fi/visual-editor.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-23T16:36:42.670Z
Learnt from: benlife5
Repo: yext/visual-editor PR: 958
File: packages/visual-editor/locales/ro/visual-editor.json:394-394
Timestamp: 2025-12-23T16:36:42.670Z
Learning: In Romanian locale files (ro), "Top" is an acceptable translation for directional terms like "top_direction" rather than the native Romanian "Sus". The maintainer benlife5 confirmed this is the preferred translation in packages/visual-editor/locales/ro/visual-editor.json.
Applied to files:
packages/visual-editor/locales/ro/visual-editor.jsonpackages/visual-editor/locales/es/visual-editor.jsonpackages/visual-editor/locales/et/visual-editor.jsonpackages/visual-editor/locales/pt/visual-editor.jsonpackages/visual-editor/locales/hu/visual-editor.jsonpackages/visual-editor/locales/sk/visual-editor.jsonpackages/visual-editor/locales/pl/visual-editor.jsonpackages/visual-editor/locales/lt/visual-editor.jsonpackages/visual-editor/locales/en-GB/visual-editor.jsonpackages/visual-editor/locales/da/visual-editor.jsonpackages/visual-editor/locales/lv/visual-editor.jsonpackages/visual-editor/locales/hr/visual-editor.jsonpackages/visual-editor/locales/tr/visual-editor.jsonpackages/visual-editor/locales/cs/visual-editor.jsonpackages/visual-editor/locales/en/visual-editor.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call_unit_test / unit_tests (22.x)
- GitHub Check: call_unit_test / unit_tests (24.x)
- GitHub Check: call_unit_test / unit_tests (20.x)
- GitHub Check: semgrep/ci
🔇 Additional comments (23)
packages/visual-editor/locales/nb/visual-editor.json (1)
290-290: LGTM! Localization update aligns with PR objectives.The locale key rename from
mediaOrientationtomediaPositionand its corresponding Norwegian translation update are correct and consistent with the PR's goal of renaming "Media Orientation" to "Media Position" throughout the application.packages/visual-editor/locales/de/visual-editor.json (1)
295-295: LGTM! Locale key and translation updated correctly.The rename from
mediaOrientationtomediaPositionaligns with the PR objectives, and the German translation "Medienposition" appears accurate for "Media Position".packages/visual-editor/locales/et/visual-editor.json (1)
290-290: LGTM! Translation is accurate.The Estonian translation "Meedia positsioon" correctly translates "Media Position" and aligns with the PR objective to rename the media orientation field. The JSON syntax is valid.
packages/visual-editor/locales/tr/visual-editor.json (1)
290-290: LGTM!The key rename from
mediaOrientationtomediaPositionand the corresponding Turkish translation update from "Medya Yönü" to "Medya Konumu" are correct and align with the PR objectives.packages/visual-editor/locales/it/visual-editor.json (1)
290-290: LGTM! Old key has been completely removed.The translation "Posizione dei media" for "Media Position" is appropriate for Italian. Verification confirms the old
mediaOrientationkey has been completely removed from the codebase and the newmediaPositionkey is consistently applied across all 25+ locale files.packages/visual-editor/locales/nl/visual-editor.json (1)
290-290: Translation quality and key removal verified.The Dutch translation "Mediapositie" for "Media Position" is accurate and follows proper compound word conventions. The new key name
mediaPositionis semantically clearer thanmediaOrientationand follows the camelCase convention used throughout the file. All references to the oldmediaOrientationkey have been updated with no stale references remaining in the codebase.packages/visual-editor/locales/hu/visual-editor.json (1)
290-290: LGTM! Translation looks accurate.The key rename from
mediaOrientationtomediaPositionwith the Hungarian translation "Média pozíció" aligns with the PR objectives and is grammatically correct. Verification confirms the migration is complete—no references to the oldmediaOrientationkey remain in the codebase, the JSON is valid, and the change has been consistently applied across all 10+ locale files.packages/visual-editor/locales/da/visual-editor.json (1)
297-297: Locale key successfully renamed across all languages.The key rename from
mediaOrientationtomediaPositionwith the Danish translation "Medieposition" is correct. Verification confirms the old key has been completely removed from the codebase andmediaPositionis consistently applied across all 24 supported locale files and the source code (PromoSection.tsx:133).packages/visual-editor/locales/sk/visual-editor.json (1)
291-291: LGTM! Locale key rename is clean and consistent.The rename from
mediaOrientationtomediaPositionis properly implemented with an appropriate Slovak translation. This aligns with the broader UI improvement across all locales in this PR.packages/visual-editor/locales/es/visual-editor.json (1)
289-289: LGTM! Spanish translation is accurate.The locale key has been correctly updated to
mediaPositionwith an appropriate Spanish translation that conveys "Media Position".packages/visual-editor/locales/ja/visual-editor.json (1)
290-290: LGTM! Japanese translation is appropriate.The key has been correctly renamed to
mediaPositionwith a proper Japanese translation (メディアの位置).packages/visual-editor/locales/pt/visual-editor.json (1)
290-290: LGTM! Portuguese translation is correct.The locale key has been properly updated to
mediaPositionwith an accurate Portuguese translation.packages/visual-editor/locales/en/visual-editor.json (1)
289-289: LGTM! Migration tomediaPositionis complete.The English base translation has been updated from
mediaOrientationtomediaPosition, which is clearer and more accurate. Verification confirms no remaining references to the old key exist in the codebase or locale files.packages/visual-editor/locales/fr/visual-editor.json (1)
289-289: LGTM! Locale key rename is correct.The locale key rename from
mediaOrientationtomediaPositionis structurally correct and the French translation has been appropriately updated to reflect "Position médiatique".packages/visual-editor/locales/zh/visual-editor.json (1)
290-290: LGTM! Locale migration frommediaOrientationtomediaPositionis complete across all languages.The key rename is correctly implemented in all 25 locale files with proper translations. No remaining references to the old
mediaOrientationkey were found in the codebase.packages/visual-editor/locales/sv/visual-editor.json (1)
291-291: No action needed — locale key rename is complete.The migration from
mediaOrientationtomediaPositionis correctly implemented across the codebase. No stale references to the old key remain, and all 25 locale files (including Swedish) have been updated consistently. The code in PromoSection.tsx properly references the new key.packages/visual-editor/locales/ro/visual-editor.json (1)
290-290: LGTMThe translation key rename from
mediaOrientationtomediaPositionand the Romanian translation "Poziția media" are correct. All code references have been properly updated—no orphaned references to the old key remain, and the new key is actively being used in PromoSection.tsx.packages/visual-editor/locales/lv/visual-editor.json (1)
290-290: Translation key renamed correctly and consistently applied.The translation key has been properly updated from
mediaOrientationtomediaPosition, and the Latvian translation "Mediju pozīcija" (Media Position) is semantically appropriate. The old key has been completely removed from the codebase, and the change is consistently applied across all 24 locale files. This change aligns with the PR objectives to rename the field in the promo section.packages/visual-editor/locales/cs/visual-editor.json (1)
297-297: LGTM! Clean locale key rename across all locales.The key rename from
mediaOrientationtomediaPositionwith the Czech translation "Pozice médií" is correct and properly implemented. The old key has been completely removed from the codebase, and the new key is consistently present across all locale files.packages/visual-editor/locales/lt/visual-editor.json (1)
290-290: Locale key successfully renamed across all translations.The translation "Žiniasklaidos pozicija" (Media Position) correctly replaces the old "mediaOrientation" key, aligning with the PR objective. Verification confirms the migration is complete: all 24+ locale files have been updated to use "mediaPosition", and no remaining references to "mediaOrientation" exist in the codebase.
packages/visual-editor/locales/en-GB/visual-editor.json (1)
289-289: Approved. ThemediaPositionkey change is correct and the migration frommediaOrientationis complete across all 25 locale files and code references. No stale references remain.packages/visual-editor/locales/pl/visual-editor.json (1)
291-291: LGTM! Clean key rename frommediaOrientationtomediaPosition.The translation "Pozycja medialna" is appropriate for "Media Position" in Polish. The change is consistent across all 26 locale files with properly localized translations, and PromoSection.tsx correctly references the new key. No remaining references to the old key exist in the codebase.
packages/visual-editor/locales/hr/visual-editor.json (1)
290-290: LGTM! The locale key rename frommediaOrientationtomediaPositionis correctly implemented across all 26 locale files. The nested key structure (fields.mediaPosition) matches the code usage in PromoSection.tsx, and the Croatian translation "Položaj medija" is appropriate.
packages/visual-editor/src/components/pageSections/PromoSection.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx
Outdated
Show resolved
Hide resolved
|
Sorry, I wasn't clear -- let's rename the labels in the updated Promo Section |
@benlife5 Just curious, Shall I do the same in HeroSection as well? I see the same labels used there as well. 
|
|
Hero doesn't have the option for a video so I think keeping it as "Image" is best |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @packages/visual-editor/locales/zh-TW/visual-editor.json:
- Line 295: The translation for the JSON key "mobileMediaPosition" uses "移動媒體定位"
which is inconsistent with other keys; update the value for
"mobileMediaPosition" to "移動媒體位置" so it matches the existing "桌面/移動 圖像/媒體 位置"
terminology and keeps consistency with keys like "desktopMediaPosition",
"mobileImagePosition", and "desktopImagePosition".
🧹 Nitpick comments (1)
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx (1)
73-83: Consider updating JSDoc comments for consistency.While not critical, the JSDoc comments on lines 74-75 and 80-81 still reference "image" positioning. Consider updating them to "media" to match the new user-facing terminology:
- Line 74: "Positions the media to the left or right..."
- Line 80: "Positions the media to the top or bottom..."
📝 Suggested JSDoc updates
/** - * Positions the image to the left or right of the promo content on desktop (classic and compact variants). + * Positions the media to the left or right of the promo content on desktop (classic and compact variants). * @defaultValue right */ desktopImagePosition: "left" | "right"; /** - * Positions the image to the top or bottom of the promo content on mobile (classic and compact variants). + * Positions the media to the top or bottom of the promo content on mobile (classic and compact variants). * @defaultValue top */ mobileImagePosition: "top" | "bottom";
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (26)
packages/visual-editor/locales/cs/visual-editor.jsonpackages/visual-editor/locales/da/visual-editor.jsonpackages/visual-editor/locales/de/visual-editor.jsonpackages/visual-editor/locales/en-GB/visual-editor.jsonpackages/visual-editor/locales/en/visual-editor.jsonpackages/visual-editor/locales/es/visual-editor.jsonpackages/visual-editor/locales/et/visual-editor.jsonpackages/visual-editor/locales/fi/visual-editor.jsonpackages/visual-editor/locales/fr/visual-editor.jsonpackages/visual-editor/locales/hr/visual-editor.jsonpackages/visual-editor/locales/hu/visual-editor.jsonpackages/visual-editor/locales/it/visual-editor.jsonpackages/visual-editor/locales/ja/visual-editor.jsonpackages/visual-editor/locales/lt/visual-editor.jsonpackages/visual-editor/locales/lv/visual-editor.jsonpackages/visual-editor/locales/nb/visual-editor.jsonpackages/visual-editor/locales/nl/visual-editor.jsonpackages/visual-editor/locales/pl/visual-editor.jsonpackages/visual-editor/locales/pt/visual-editor.jsonpackages/visual-editor/locales/ro/visual-editor.jsonpackages/visual-editor/locales/sk/visual-editor.jsonpackages/visual-editor/locales/sv/visual-editor.jsonpackages/visual-editor/locales/tr/visual-editor.jsonpackages/visual-editor/locales/zh-TW/visual-editor.jsonpackages/visual-editor/locales/zh/visual-editor.jsonpackages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/visual-editor/locales/en/visual-editor.json
- packages/visual-editor/locales/ja/visual-editor.json
- packages/visual-editor/locales/it/visual-editor.json
- packages/visual-editor/locales/tr/visual-editor.json
- packages/visual-editor/locales/zh/visual-editor.json
- packages/visual-editor/locales/pl/visual-editor.json
- packages/visual-editor/locales/fi/visual-editor.json
- packages/visual-editor/locales/ro/visual-editor.json
- packages/visual-editor/locales/lv/visual-editor.json
- packages/visual-editor/locales/da/visual-editor.json
- packages/visual-editor/locales/et/visual-editor.json
- packages/visual-editor/locales/en-GB/visual-editor.json
- packages/visual-editor/locales/sv/visual-editor.json
- packages/visual-editor/locales/nb/visual-editor.json
- packages/visual-editor/locales/cs/visual-editor.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-23T16:30:55.497Z
Learnt from: benlife5
Repo: yext/visual-editor PR: 958
File: packages/visual-editor/src/components/pageSections/heroVariants/CompactHero.tsx:38-41
Timestamp: 2025-12-23T16:30:55.497Z
Learning: In CompactHero and CompactPromo components, duplicate IDs on image elements are intentional: conditional visibility classes (hidden/sm:block/sm:hidden) ensure only one image renders at a time based on responsive breakpoints and desktopImagePosition/mobileImagePosition settings.
Applied to files:
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call_unit_test / unit_tests (20.x)
- GitHub Check: call_unit_test / unit_tests (24.x)
- GitHub Check: call_unit_test / unit_tests (22.x)
- GitHub Check: semgrep/ci
🔇 Additional comments (12)
packages/visual-editor/locales/es/visual-editor.json (1)
213-213: LGTM! New locale keys added correctly.The new
desktopMediaPositionandmobileMediaPositionkeys are properly added to support the label rename in PromoSection. The existingdesktopImagePositionandmobileImagePositionkeys remain intact, which correctly avoids the need for data migration.Also applies to: 294-294
packages/visual-editor/locales/hr/visual-editor.json (1)
214-214: LGTM! Locale keys added consistently.The Croatian translations for
desktopMediaPositionandmobileMediaPositionare properly added, matching the pattern used in other locale files.Also applies to: 295-295
packages/visual-editor/locales/fr/visual-editor.json (1)
213-213: LGTM! French locale keys added correctly.The new media position translation keys are properly added to the French locale file, maintaining consistency with the multilingual rollout.
Also applies to: 294-294
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx (1)
191-210: LGTM! Label changes implemented correctly.The implementation correctly updates only the user-facing labels via
msg()calls while keeping the underlying field names (desktopImagePosition,mobileImagePosition) unchanged. This avoids the need for a data migration, as requested in the PR comments.packages/visual-editor/locales/pt/visual-editor.json (1)
214-214: LGTM! Portuguese locale keys added correctly.The Portuguese translations for the new media position labels are properly added, completing the multilingual locale updates for this feature.
Also applies to: 295-295
packages/visual-editor/locales/hu/visual-editor.json (1)
214-214: LGTM! Clean localization additions for Media Position labels.The new translation keys support the PromoSection label changes from "Image Position" to "Media Position" while keeping the underlying object keys unchanged (as required to avoid migration). The Hungarian translations follow proper grammar patterns and are correctly positioned adjacent to the existing image position keys.
Also applies to: 295-295
packages/visual-editor/locales/de/visual-editor.json (1)
218-218: LGTM! Consistent with the localization approach.The German translations mirror the structure used in the Hungarian locale file, properly supporting the PromoSection label updates. The compound noun "Medienposition" is grammatically correct and follows German language conventions.
Also applies to: 300-300
packages/visual-editor/locales/zh-TW/visual-editor.json (1)
214-214: LGTM!The translation "桌面媒體位置" correctly conveys "Desktop Media Position" and uses consistent terminology with the existing
desktopImagePositionfield.packages/visual-editor/locales/lt/visual-editor.json (2)
214-214: LGTM: New locale keys added consistently across all files.Both
desktopMediaPositionandmobileMediaPositionkeys have been correctly added to all 25 locale files. The keys are appropriately positioned adjacent to their corresponding image position keys (desktopImagePositionandmobileImagePosition), maintaining backward compatibility and avoiding migration requirements.
295-295: LGTM: Mobile media position key is consistently added across all locale files.The
mobileMediaPositionkey has been added uniformly across all 25 locale files and is appropriately positioned next tomobileImagePosition, maintaining the parallel structure for desktop and mobile configurations.packages/visual-editor/locales/sk/visual-editor.json (1)
215-215: Approved. New Slovak translations for media position labels added correctly.Both
desktopMediaPositionandmobileMediaPositionkeys are referenced inPromoSection.tsxvia themsg()function and properly included in the Slovak localization file. The translations consistently replace "obraz" (image) with "média" (media), aligning with the UI label rename across the PromoSection component.packages/visual-editor/locales/nl/visual-editor.json (1)
214-214: [rewritten comment]
[classification tag]
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In
@packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx:
- Line 192: Remove the stale locale keys fields.desktopImagePosition and
fields.mobileImagePosition from the English locale files; specifically open
packages/visual-editor/locales/en/visual-editor.json and
packages/visual-editor/locales/en-GB/visual-editor.json and delete the entries
for "fields.desktopImagePosition" and "fields.mobileImagePosition" (they were
replaced by fields.desktopMediaPosition and fields.mobileMediaPosition
referenced via msg("fields.desktopMediaPosition", ...) in PromoSection and other
code).
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsxpackages/visual-editor/src/docs/ai/components.d.tspackages/visual-editor/src/docs/components.md
✅ Files skipped from review due to trivial changes (1)
- packages/visual-editor/src/docs/ai/components.d.ts
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-23T16:30:55.497Z
Learnt from: benlife5
Repo: yext/visual-editor PR: 958
File: packages/visual-editor/src/components/pageSections/heroVariants/CompactHero.tsx:38-41
Timestamp: 2025-12-23T16:30:55.497Z
Learning: In CompactHero and CompactPromo components, the 2xl breakpoint applies unconditional left padding because once the container reaches max-width (1440px), the design requires centering with consistent left padding regardless of desktopImagePosition.
Applied to files:
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsxpackages/visual-editor/src/docs/components.md
📚 Learning: 2025-12-23T16:30:55.497Z
Learnt from: benlife5
Repo: yext/visual-editor PR: 958
File: packages/visual-editor/src/components/pageSections/heroVariants/CompactHero.tsx:38-41
Timestamp: 2025-12-23T16:30:55.497Z
Learning: In CompactHero and CompactPromo components, duplicate IDs on image elements are intentional: conditional visibility classes (hidden/sm:block/sm:hidden) ensure only one image renders at a time based on responsive breakpoints and desktopImagePosition/mobileImagePosition settings.
Applied to files:
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsxpackages/visual-editor/src/docs/components.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call_unit_test / unit_tests (24.x)
- GitHub Check: call_unit_test / unit_tests (22.x)
- GitHub Check: call_unit_test / unit_tests (20.x)
- GitHub Check: semgrep/ci
🔇 Additional comments (2)
packages/visual-editor/src/docs/components.md (1)
695-697: LGTM! Documentation accurately reflects media support.The updated descriptions correctly generalize from "image" to "media" to reflect that these position properties apply to both images and videos, while appropriately keeping the property names unchanged.
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx (1)
74-74: LGTM! JSDoc comments accurately updated.The documentation comments correctly generalize from "image" to "media" to reflect support for both images and videos.
Also applies to: 80-80
packages/visual-editor/src/components/pageSections/PromoSection/PromoSection.tsx
Show resolved
Hide resolved
Tickets - [OPAQF-19,](https://yext.atlassian.net/browse/OPAQF-19), [OPAQF-84](https://yext.atlassian.net/browse/OPAQF-84). - Renamed Media orientation to Media Position in promo section. - Added default truncate field. Didn't run any test cases as there may not be any noticeable visual difference. https://github.com/user-attachments/assets/261881e0-5717-4576-8548-abeef9395a4c --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
3 participants
Tickets - OPAQF-19,, OPAQF-84.
Didn't run any test cases as there may not be any noticeable visual difference.
Screen.Recording.2026-01-05.at.7.08.13.PM.mov