Skip to content

feat: placeholder image for header/footer logo #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlife5 merged 4 commits into from
Dec 16, 2025
Merged

feat: placeholder image for header/footer logo #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f846e94
team updates and logo placeholder
benlife5 Dec 16, 2025
f059f9c
Update component screenshots for visual-editor
github-actions[bot] Dec 16, 2025
3f25424
update default footer
benlife5 Dec 16, 2025
81f370f
Update component screenshots for visual-editor
github-actions[bot] Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/visual-editor/src/components/footer/ExpandedFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import {
} from "@yext/visual-editor";
import { defaultCopyrightMessageSlotProps } from "./CopyrightMessageSlot.tsx";

const PLACEHOLDER_LOGO_IMAGE: string = "https://placehold.co/100";
const PLACEHOLDER_LOGO_IMAGE: string =
"https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg";

export const defaultLink = {
linkType: "URL" as const,
Expand Down Expand Up @@ -328,7 +329,7 @@ export const ExpandedFooter: ComponentConfig<{ props: ExpandedFooterProps }> = {
},
styles: {
width: 100,
aspectRatio: 1.78,
aspectRatio: 1,
},
},
},
Expand Down
5 changes: 3 additions & 2 deletions packages/visual-editor/src/components/footer/FooterLogoSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ export const FooterLogoSlot: ComponentConfig<{ props: FooterLogoSlotProps }> = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
// Placeholder logo, uploaded to account 4174974
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
alternateText: { en: "Logo", hasLocalizedValue: "true" },
Expand All @@ -109,7 +110,7 @@ export const FooterLogoSlot: ComponentConfig<{ props: FooterLogoSlotProps }> = {
},
styles: {
width: 0,
aspectRatio: 1.78,
aspectRatio: 1,
},
},
render: (props) => <FooterLogoSlotInternal {...props} />,
Expand Down
5 changes: 3 additions & 2 deletions packages/visual-editor/src/components/header/PrimaryHeaderSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,15 +233,16 @@ export const defaultPrimaryHeaderProps: PrimaryHeaderSlotProps = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
// Placeholder logo, uploaded to account 4174974
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
},
constantValueEnabled: true,
},
},
styles: {
aspectRatio: 2,
aspectRatio: 1,
width: 100,
},
} satisfies ImageWrapperProps,
Expand Down
6 changes: 3 additions & 3 deletions packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ const defaultPerson = {
ctaType: "textAndLink",
},
headshot: {
url: "https://dyn.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/width=80,height=80",
// Placeholder headshot, uploaded to account 4174974
url: "https://a.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/196x196.jpg",
height: 80,
width: 80,
},
Expand Down Expand Up @@ -522,8 +523,7 @@ export const TeamCard: ComponentConfig<{ props: TeamCardProps }> = {
"max-w-full h-full object-cover"
);
updatedData = setDeep(updatedData, "props.slots.ImageSlot[0].props.sizes", {
base: "calc(100vw - 32px)",
lg: "calc(maxWidth * 0.33)",
base: "80px",
} satisfies ImgSizesByBreakpoint);

// Set the CTA's event name
Expand Down
Binary file modified ...r/src/components/testing/screenshots/ExpandedFooter/[desktop] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...or/src/components/testing/screenshots/ExpandedFooter/[mobile] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...or/src/components/testing/screenshots/ExpandedFooter/[tablet] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...r/src/components/testing/screenshots/ExpandedHeader/[desktop] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ting/screenshots/ExpandedHeader/[mobile] default props (after interactions).png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...or/src/components/testing/screenshots/ExpandedHeader/[mobile] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...or/src/components/testing/screenshots/ExpandedHeader/[tablet] default props.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 11 additions & 11 deletions packages/visual-editor/src/vite-plugin/defaultLayoutData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ const mainDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
},
constantValueEnabled: true,
},
},
styles: { aspectRatio: 2, width: 100 },
styles: { aspectRatio: 1, width: 100 },
},
},
],
Expand Down Expand Up @@ -1781,7 +1781,7 @@ const mainDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://dyn.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/width=80,height=80",
url: "https://a.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/196x196.jpg",
height: 80,
width: 80,
},
Expand Down Expand Up @@ -1946,7 +1946,7 @@ const mainDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://dyn.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/width=80,height=80",
url: "https://a.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/196x196.jpg",
height: 80,
width: 80,
},
Expand Down Expand Up @@ -2109,7 +2109,7 @@ const mainDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://dyn.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/width=80,height=80",
url: "https://a.mktgcdn.com/p/EQRaOZG5zFlcbEHYaH16EV6WmkzV8kd6vMd73Myg4AA/196x196.jpg",
height: 80,
width: 80,
},
Expand Down Expand Up @@ -3422,15 +3422,15 @@ const mainDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
alternateText: { en: "Logo", hasLocalizedValue: "true" },
},
constantValueEnabled: true,
},
},
styles: { width: 100, aspectRatio: 1.78 },
styles: { width: 100, aspectRatio: 1 },
},
},
],
Expand Down Expand Up @@ -3835,14 +3835,14 @@ const directoryDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
},
constantValueEnabled: true,
},
},
styles: { aspectRatio: 2, width: 100 },
styles: { aspectRatio: 1, width: 100 },
},
},
],
Expand Down Expand Up @@ -4157,15 +4157,15 @@ const directoryDefaultLayout = {
image: {
field: "",
constantValue: {
url: "https://placehold.co/100",
url: "https://a.mktgcdn.com/p/wa83C1O1lvtxHI9cGqEdP2HILyUzbD0jvtzwWpOAJfE/196x196.jpg",
height: 100,
width: 100,
alternateText: { en: "Logo", hasLocalizedValue: "true" },
},
constantValueEnabled: true,
},
},
styles: { width: 100, aspectRatio: 1.78 },
styles: { width: 100, aspectRatio: 1 },
},
},
],
Expand Down