chore: upgrade pages-components to 1.1.16

[briantstephan]

No description provided.

[coderabbitai]

Walkthrough

This PR consolidates formatting and cleanup changes across the visual-editor package. It bumps THIRD-PARTY-NOTICES version strings for multiple dependencies, removes TypeScript error suppression comments from component style properties, and reformats interface extends clauses and conditional expressions for consistency. No behavioral or control-flow modifications are present; all changes are purely stylistic or documentation-related.

Possibly related PRs

• fix: slots qa part 2 #859: Modifies TestimonialCard.tsx alongside this PR to update timestamp slot shape and imports.

Suggested reviewers

• mkilpatrick
• colton-demetriou
• asanehisa

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author. While a description would be helpful for context, the absence of one is not inherently problematic given the clear and self-explanatory title and straightforward nature of the changes.	Consider adding a brief description explaining the purpose of the upgrade, any breaking changes, or testing performed to improve clarity for reviewers.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: upgrading pages-components to version 1.1.16. It is concise, specific, and clearly summarizes the primary objective of the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch upgrade-pages-components

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[colton-demetriou]

are these errors real

[asanehisa]

are these errors real

Hmm we shouldn't merge w/ these errors

[github-actions]

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

tests failed

[pkg-pr-new]

• pages-visual-editor-starter

  npm i https://pkg.pr.new/yext/visual-editor/@yext/visual-editor@898
  

commit: 418375e

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx (1)

453-460: Consider guarding dateTimeSlotProps before accessing .data to avoid a possible crash

showDateTime currently evaluates resolveYextEntityField(..., dateTimeSlotProps.data.date, ...) even when dateTimeSlotProps might be undefined (e.g., an empty DateTimeSlot array), which would throw at runtime if that situation occurs. Even if config invariants make this “impossible”, a small guard would make the code more defensive.

You can keep the existing behavior while making it safer by short‑circuiting on dateTimeSlotProps:

-    const showDateTime = Boolean(
-      dateTimeSlotProps?.parentData?.date?.trim() ||
-      resolveYextEntityField(
-        params.metadata.streamDocument,
-        dateTimeSlotProps.data.date,
-        i18nComponentsInstance.language || "en"
-      )?.trim()
-    );
+    const showDateTime = Boolean(
+      dateTimeSlotProps &&
+        (dateTimeSlotProps.parentData?.date?.trim() ||
+          resolveYextEntityField(
+            params.metadata.streamDocument,
+            dateTimeSlotProps.data.date,
+            i18nComponentsInstance.language || "en"
+          )?.trim())
+    );

This keeps the same truthiness semantics when the slot exists, but avoids touching .data when it doesn’t.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d57787b and 9bc83e7.

📒 Files selected for processing (12)

• packages/visual-editor/THIRD-PARTY-NOTICES (11 hunks)
• packages/visual-editor/src/components/atoms/body.tsx (1 hunks)
• packages/visual-editor/src/components/atoms/button.tsx (1 hunks)
• packages/visual-editor/src/components/atoms/heading.tsx (1 hunks)
• packages/visual-editor/src/components/atoms/hoursTable.tsx (1 hunks)
• packages/visual-editor/src/components/atoms/pageSection.tsx (1 hunks)
• packages/visual-editor/src/components/configs/directoryConfig.tsx (1 hunks)
• packages/visual-editor/src/components/configs/locatorConfig.tsx (1 hunks)
• packages/visual-editor/src/components/configs/mainConfig.tsx (1 hunks)
• packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx (1 hunks)
• packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx (1 hunks)
• packages/visual-editor/src/components/pageSections/TestimonialSection/TestimonialCard.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (8)

• packages/visual-editor/src/components/configs/locatorConfig.tsx
• packages/visual-editor/src/components/atoms/heading.tsx
• packages/visual-editor/src/components/atoms/body.tsx
• packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx
• packages/visual-editor/src/components/configs/mainConfig.tsx
• packages/visual-editor/src/components/atoms/hoursTable.tsx
• packages/visual-editor/src/components/pageSections/TestimonialSection/TestimonialCard.tsx
• packages/visual-editor/src/components/atoms/pageSection.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/visual-editor/src/components/atoms/button.tsx
• packages/visual-editor/THIRD-PARTY-NOTICES

🧰 Additional context used

🧬 Code graph analysis (1)

packages/visual-editor/src/components/configs/directoryConfig.tsx (1)

packages/visual-editor/src/components/categories/DirectoryCategory.tsx (1)

• DirectoryCategoryProps (3-5)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: call_unit_test / unit_tests (20.x)
• GitHub Check: call_unit_test / unit_tests (18.x)
• GitHub Check: create-dev-release
• GitHub Check: semgrep/ci

🔇 Additional comments (3)

packages/visual-editor/src/components/pageSections/EventSection/EventCard.tsx (2)

433-452: Conditional render for description/title remains behaviorally identical

This block still does slotProps && (parentData ? parentDataValue : resolvedEntityField), so the short‑circuiting and fallback behavior are unchanged; only whitespace/line‑breaks moved. No action needed here.

---

461-470: CTA conditional render formatting is a no‑op change

The CTA visibility logic is still ctaSlotProps && (parentData ? parentData.cta.label : resolveComponentData(...).label). Only indentation/line‑breaking changed, so behavior is preserved.

packages/visual-editor/src/components/configs/directoryConfig.tsx (1)

24-29: Multi‑line extends formatting only; no behavior change

Splitting the DirectoryConfigProps extends list across multiple lines doesn’t affect typing or the resulting config; it just improves readability and matches the style used elsewhere.

[briantstephan]

Looks like main is already on 1.1.16