fix: directory title redirects and props #894

colton-demetriou · 2025-11-11T18:32:59Z

Added functionality so that props are actually saved for directory cards, also added "disabled" link functionality so that you can click on the heading slot without being redirected to the child entity. Lastly, added local dev data to be able to test the directory locally. This should also resolve the 404 issue that was being seen on the redirect since it's no longer a link in the editor (I assume the child being redirected to in the bug bash no longer existed or something).

github-actions · 2025-11-11T18:33:24Z

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

coderabbitai · 2025-11-11T18:33:56Z

Walkthrough

This PR adds a disabled?: boolean prop to CTA and MaybeLink and implements disabled rendering (CTA renders a non-interactive Button when disabled is true). DirectoryCard gains an optional existingSlots parameter used to seed slot-level styles and options; DirectoryWrapper now passes existing slot data when regenerating cards to preserve slot configurations. CTA link rendering width defaults were adjusted (w-fit unless forced full width). A timestamped Vite config module with screenshot-compare helpers was added, and starter directory JSON was updated with explicit slugs, metadata, and URL templates.

Sequence Diagram(s)

sequenceDiagram
    participant DW as DirectoryWrapper
    participant DC as DirectoryCard
    participant ML as MaybeLink
    participant CTA as CTA

    Note over DW: resolveData regenerates cards preserving styles + slots
    DW->>DC: defaultDirectoryCardSlotData(id,index,profile,styles, existingSlots)
    DC->>DC: Populate slot props from existingSlots when present
    DC->>DW: Return DirectoryCardProps with slots populated
    DW->>DW: setDeep updates props.slots.CardSlot[i]

    Note over DC: Runtime rendering of heading/link
    DC->>ML: Render MaybeLink(href, disabled = puck.isEditing)
    alt puck.isEditing = true
        ML->>CTA: CTA(href, disabled=true)
        CTA->>CTA: Render Button (non-interactive) with linkContent
    else puck.isEditing = false
        ML->>CTA: CTA(href, disabled=false)
        CTA->>CTA: Render Link with linkContent (label + caret)
    end

Possibly related PRs

feat: use ref_listings #846: Modifies CTA props and link resolution; touches the same CTA component API.
fix: slots qa part 2 #859: Adjusts CTA sizing/width behavior (className changes like w-fit / w-full) related to this PR.

Suggested reviewers

mkilpatrick
benlife5
briantstephan

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: directory title redirects and props' directly relates to the main changes: fixing redirect behavior and persisting props for directory cards.
Description check	✅ Passed	The description accurately outlines the key changes: prop persistence for directory cards, disabled link functionality to prevent unwanted redirects, and local dev data for testing.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch neaby-locations-fix

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eafaf14 and 18ea1ca.

📒 Files selected for processing (1)

packages/visual-editor/src/components/pageSections/NearbyLocations/NearbyLocations.tsx (1 hunks)

packages/visual-editor/src/components/pageSections/NearbyLocations/NearbyLocations.tsx

pkg-pr-new · 2025-11-11T18:35:13Z

pages-visual-editor-starter

npm i https://pkg.pr.new/yext/visual-editor/@yext/visual-editor@894

commit: a9f55ae

…al dev

...omponents/testing/screenshots/CoreInfoSection/[desktop] default props with document data.png

coderabbitai

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/visual-editor/src/components/directory/DirectoryCard.tsx (1)

51-121: Preserve existing slot style fields before applying defaults.

When resolveData rebuilds cards, these new objects replace the entire styles payload for the HeadingSlot, PhoneSlot, and HoursSlot. Because we don’t spread the existing styles first, any user-defined keys (for example a custom styles.className on the PhoneSlot) are wiped the moment the directory re-syncs with stream data. Please merge the previous styles before layering the defaults so we don’t regress saved customizations.

Apply this diff:

             styles: {
+              ...existingSlots?.HeadingSlot?.[0]?.props?.styles,
               level: existingSlots?.HeadingSlot?.[0]?.props?.styles?.level ?? 3,
               align:
                 existingSlots?.HeadingSlot?.[0]?.props?.styles?.align ?? "left",
             },
@@
             styles: {
+              ...existingSlots?.PhoneSlot?.[0]?.props?.styles,
               phoneFormat:
                 existingSlots?.PhoneSlot?.[0]?.props?.styles?.phoneFormat ??
                 "domestic",
               includePhoneHyperlink:
                 existingSlots?.PhoneSlot?.[0]?.props?.styles
                   ?.includePhoneHyperlink ?? true,
               includeIcon:
                 existingSlots?.PhoneSlot?.[0]?.props?.styles?.includeIcon ??
                 false,
             },
@@
             styles: {
+              ...existingSlots?.HoursSlot?.[0]?.props?.styles,
               dayOfWeekFormat:
                 existingSlots?.HoursSlot?.[0]?.props?.styles?.dayOfWeekFormat ??
                 "long",
               showDayNames:
                 existingSlots?.HoursSlot?.[0]?.props?.styles?.showDayNames ??

🧹 Nitpick comments (1)

packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs (1)

156-177: Optional: Reduce duplication in cssStubPlugin.

The conditional logic checking CSS file patterns is duplicated between resolveId and load hooks. Consider extracting to a helper function for maintainability.

+const shouldStubCss = (id: string) => 
+  (id.endsWith(".css") || id.endsWith(".scss")) &&
+  !id.endsWith("componentTests.css") &&
+  !id.endsWith("style.css");
+
 const cssStubPlugin: Plugin = {
   name: "css-stub",
   enforce: "pre",
   resolveId(id) {
-    if (
-      (id.endsWith(".css") || id.endsWith(".scss")) &&
-      !id.endsWith("componentTests.css") &&
-      !id.endsWith("style.css")
-    ) {
+    if (shouldStubCss(id)) {
       return id;
     }
   },
   load(id) {
-    if (
-      (id.endsWith(".css") || id.endsWith(".scss")) &&
-      !id.endsWith("componentTests.css") &&
-      !id.endsWith("style.css")
-    ) {
+    if (shouldStubCss(id)) {
       return "export default {}";
     }
   },
 };

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18ea1ca and 5c8e93f.

⛔ Files ignored due to path filters (77)

packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 1 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 1 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 1 props with partial entity values 1.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 1 props with partial entity values 2.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[desktop] version 26 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 1 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 1 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 1 props with partial entity values 1.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 1 props with partial entity values 2.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[mobile] version 26 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 1 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 1 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 1 props with partial entity values 1.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 1 props with partial entity values 2.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/CoreInfoSection/[tablet] version 26 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[desktop] version 14 with cityDocument and default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[desktop] version 18 with cityDocument and siteName field.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 14 with cityDocument and default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 18 with cityDocument and siteName field.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[tablet] version 14 with cityDocument and default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[tablet] version 18 with cityDocument and siteName field.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/EventSection/[desktop] version 25 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/EventSection/[mobile] version 25 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/EventSection/[tablet] version 25 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[desktop] version 28 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[mobile] version 28 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 18 - atoms used to make a CoreInfoSection.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 19 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 19 - various atoms.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Grid/[tablet] version 28 - various CTAs.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Header/[mobile] default props with document data (after interactions).png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Header/[mobile] version 2 props (after interactions).png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/ProductSection/[desktop] version 31 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/ProductSection/[mobile] version 31 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/ProductSection/[tablet] version 31 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[desktop] version 29 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[mobile] version 29 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/PromoSection/[tablet] version 29 props with mixed values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] default props with empty document.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 33 props with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 33 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 7 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[desktop] version 7 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] default props with empty document.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 33 props with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 33 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 7 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[mobile] version 7 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] default props with document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] default props with empty document.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 0 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 0 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 33 props with constant values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 33 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 7 props with constant value.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/TeamSection/[tablet] version 7 props with entity values.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

📒 Files selected for processing (6)

packages/visual-editor/src/components/atoms/cta.tsx (5 hunks)
packages/visual-editor/src/components/atoms/maybeLink.tsx (3 hunks)
packages/visual-editor/src/components/directory/DirectoryCard.tsx (6 hunks)
packages/visual-editor/src/components/directory/DirectoryWrapper.tsx (1 hunks)
packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs (1 hunks)
starter/localData/dev-dm-city-stream__en__8932945.json (5 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

packages/visual-editor/src/components/directory/DirectoryWrapper.tsx (1)

packages/visual-editor/src/components/directory/DirectoryCard.tsx (1)

defaultDirectoryCardSlotData (22-136)

packages/visual-editor/src/components/directory/DirectoryCard.tsx (1)

packages/visual-editor/src/components/atoms/maybeLink.tsx (1)

MaybeLink (15-44)

packages/visual-editor/src/components/atoms/cta.tsx (1)

packages/visual-editor/src/components/atoms/button.tsx (1)

Button (89-115)

🔇 Additional comments (1)

packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs (1)

68-142: This review comment is incorrect—the referenced .mjs file is not part of this PR.

The PR contains only PNG image changes. Neither packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs nor the source vite.config.ts are included in the PR diff. The .mjs file is a temporary Vite build artifact that exists on disk but is not staged or committed. The source vite.config.ts is properly maintained and unmodified by this PR.

Likely an incorrect or invalid review comment.

packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs

...ts/testing/screenshots/Directory/[tablet] version 14 with cityDocument and default props.png

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 314a3c0 and a47c77a.

⛔ Files ignored due to path filters (13)

packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] default props - country - document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] default props - region - document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] default props - root - document data.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 11 with default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 39 with countryDocument and default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 4 - directory list - default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 4 - directory list - non-default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 7 - directory list - default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 7 - directory list - non-default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 8 - country - default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 8 - directory list - non-default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 8 - region - default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 8 - root - default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

📒 Files selected for processing (2)

packages/visual-editor/src/components/atoms/cta.tsx (4 hunks)
packages/visual-editor/src/components/directory/DirectoryCard.tsx (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/visual-editor/src/components/directory/DirectoryCard.tsx

🧰 Additional context used

🧬 Code graph analysis (1)

packages/visual-editor/src/components/atoms/cta.tsx (1)

packages/visual-editor/src/components/atoms/button.tsx (1)

Button (89-115)

🔇 Additional comments (2)

packages/visual-editor/src/components/atoms/cta.tsx (2)

29-29: LGTM! Clean addition of the disabled prop.

The disabled prop is properly typed as optional and defaults to false, maintaining backward compatibility.

Also applies to: 141-141

159-179: LGTM! Good refactor to eliminate duplication.

Extracting the linkContent into a shared variable eliminates duplication between the disabled and normal rendering paths while preserving all the original caret visibility logic.

packages/visual-editor/src/components/atoms/cta.tsx

packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs

packages/visual-editor/src/components/atoms/cta.tsx

...s/testing/screenshots/Directory/[desktop] version 14 with cityDocument and default props.png

test

18ea1ca

colton-demetriou added the create-dev-release Triggers dev release workflow label Nov 11, 2025

coderabbitai bot reviewed Nov 11, 2025

View reviewed changes

packages/visual-editor/src/components/pageSections/NearbyLocations/NearbyLocations.tsx Outdated Show resolved Hide resolved

colton-demetriou changed the title ~~test~~ fix: nearby locations 404 Nov 11, 2025

asanehisa marked this pull request as draft November 11, 2025 19:44

coltondemetriou and others added 8 commits November 11, 2025 15:03

maybe fix

31c851a

rm comment

335830d

mock value but prevent redirect for cta styling

76f71ef

add disabled for links

fc5c54f

render link as button when disabled, add content for directory in loc…

242c8ea

…al dev

add directory changes

78e4875

respect props on live page and in editore

e3d150f

Update component screenshots for visual-editor

5c8e93f

colton-demetriou changed the title ~~fix: nearby locations 404~~ fix: directory title redirects and props Nov 11, 2025

colton-demetriou assigned mkilpatrick, briantstephan, benlife5 and asanehisa Nov 11, 2025

colton-demetriou marked this pull request as ready for review November 11, 2025 21:31

colton-demetriou commented Nov 11, 2025

View reviewed changes

...omponents/testing/screenshots/CoreInfoSection/[desktop] default props with document data.png Show resolved Hide resolved

coderabbitai bot reviewed Nov 11, 2025

View reviewed changes

coltondemetriou and others added 4 commits November 11, 2025 17:52

fix

314a3c0

Update component screenshots for visual-editor

759b1ed

test

4598e98

fix

a47c77a

colton-demetriou commented Nov 11, 2025

View reviewed changes

...ts/testing/screenshots/Directory/[tablet] version 14 with cityDocument and default props.png Show resolved Hide resolved

coderabbitai bot reviewed Nov 11, 2025

View reviewed changes

packages/visual-editor/src/components/atoms/cta.tsx Show resolved Hide resolved

Update component screenshots for visual-editor

99f4538

benlife5 reviewed Nov 12, 2025

View reviewed changes

packages/visual-editor/vite.config.ts.timestamp-1762894860199-2804037bc8f35.mjs Outdated Show resolved Hide resolved

colton-demetriou requested review from asanehisa, briantstephan and mkilpatrick November 12, 2025 16:29

rm file

a9f55ae

colton-demetriou requested a review from benlife5 November 12, 2025 16:37

benlife5 approved these changes Nov 12, 2025

View reviewed changes

briantstephan reviewed Nov 12, 2025

View reviewed changes

packages/visual-editor/src/components/atoms/cta.tsx Show resolved Hide resolved

briantstephan approved these changes Nov 12, 2025

View reviewed changes

colton-demetriou merged commit 891bbf9 into fall-2025-slot-ify-components Nov 12, 2025
16 checks passed

colton-demetriou deleted the neaby-locations-fix branch November 12, 2025 16:48

asanehisa reviewed Nov 12, 2025

View reviewed changes

...s/testing/screenshots/Directory/[desktop] version 14 with cityDocument and default props.png Show resolved Hide resolved

coderabbitai bot mentioned this pull request Nov 17, 2025

feat: add new props and styling to locator result card #905

Merged

coderabbitai bot mentioned this pull request Dec 11, 2025

feat: add color selection for CTAs #936

Merged

This was referenced Dec 29, 2025

feat: added open in new tab and center secondary footer #962

Closed

feat: added open in new tab and center aligned the secondary footer #967

Merged

This was referenced Feb 5, 2026

feat: add custom button functionality to cta #1023

Merged

feat: dynamic directory title and address converted to slots #1036

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: directory title redirects and props #894

fix: directory title redirects and props #894

Uh oh!

colton-demetriou commented Nov 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

coderabbitai bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: directory title redirects and props #894

fix: directory title redirects and props #894

Uh oh!

Conversation

colton-demetriou commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

coderabbitai bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

colton-demetriou commented Nov 11, 2025 •

edited

Loading

coderabbitai bot commented Nov 11, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 11, 2025 •

edited

Loading