Skip to content

feat: derive Get Directions link in locator from ref_listings if present #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkouzel-yext merged 1 commit into from
Nov 4, 2025
Merged

feat: derive Get Directions link in locator from ref_listings if present #860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions packages/visual-editor/src/components/Locator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,13 @@ import {
HoursStatusAtom,
} from "@yext/visual-editor";
import mapboxgl, { LngLat, LngLatBounds, MarkerOptions } from "mapbox-gl";
import { Address, AddressType, HoursType } from "@yext/pages-components";
import {
Address,
AddressType,
getDirections,
HoursType,
ListingType,
} from "@yext/pages-components";
import { MapPinIcon } from "./MapPinIcon.js";
import {
FaAngleRight,
Expand Down Expand Up @@ -1284,10 +1290,6 @@ const LocationCard = React.memo(
const location = result.rawData;
const distance = result.distance;

const getGoogleMapsLink = (coordinate: Coordinate): string => {
return `https://www.google.com/maps/dir/?api=1&destination=${coordinate.latitude},${coordinate.longitude}`;
};

const distanceInMiles = distance
? (distance / 1609.344).toFixed(1)
: undefined;
Expand Down Expand Up @@ -1323,11 +1325,24 @@ const LocationCard = React.memo(

const telHref = sanitizePhoneForTelHref(location.mainPhone);

const googleMapsLink = (() => {
if (!location.yextDisplayCoordinate) {
return null;
}
return getGoogleMapsLink(location.yextDisplayCoordinate);
const getDirectionsLink: string | undefined = (() => {
const listings = location.ref_listings ?? [];
const listingsLink = getDirections(
undefined,
listings,
undefined,
{ provider: "google" },
undefined
);
const coordinateLink = getDirections(
undefined,
undefined,
undefined,
{ provider: "google" },
location.yextDisplayCoordinate
);

return listingsLink || coordinateLink;
})();

return (
Expand Down Expand Up @@ -1391,9 +1406,9 @@ const LocationCard = React.memo(
/>
</div>
)}
{googleMapsLink && (
{getDirectionsLink && (
<a
href={googleMapsLink}
href={getDirectionsLink}
onClick={handleGetDirectionsClick}
className="components h-fit items-center w-fit underline gap-2 decoration-0 hover:no-underline font-link-fontFamily text-link-fontSize tracking-link-letterSpacing flex font-bold text-palette-primary-dark"
>
Expand Down Expand Up @@ -1646,4 +1661,5 @@ interface Location {
slug?: string;
timezone: string;
yextDisplayCoordinate?: Coordinate;
ref_listings?: ListingType[];
}