Skip to content

fix: promoSection migration with Video / Image #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asanehisa merged 4 commits into from
Nov 3, 2025
Merged

fix: promoSection migration with Video / Image #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc1cd43
fixed
asanehisa Nov 3, 2025
88c2fc5
ai comments
asanehisa Nov 3, 2025
3fdb75e
Update component screenshots for visual-editor
github-actions[bot] Nov 3, 2025
82bda33
Update component screenshots for visual-editor
github-actions[bot] Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 54 additions & 58 deletions packages/visual-editor/src/components/migrations/0029_promo_section_slots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const promoSectionSlots: Migration = {
const isVideo =
!constantValueEnabled &&
!constantValueOverride.image &&
constantValue?.image.video;
constantValue?.image?.video;

const imageStyle = props.styles.image;
const headingStyle = props.styles.heading;
Expand Down Expand Up @@ -105,65 +105,61 @@ export const promoSectionSlots: Migration = {
} satisfies WithId<BodyTextProps>,
},
],
VideoSlot: isVideo
? [
{
type: "VideoSlot",
props: {
id: `${props.id}-VideoSlot`,
data: {
assetVideo:
"video" in constantValue.image
? constantValue.image
: {},
},
} satisfies WithId<VideoProps>,
VideoSlot: [
{
type: "VideoSlot",
props: {
id: `${props.id}-VideoSlot`,
data: {
assetVideo:
isVideo && "video" in constantValue.image
? constantValue.image
: {},
},
]
: [],
ImageSlot: isVideo
? []
: [
{
type: "ImageSlot",
props: {
id: `${props.id}-ImageSlot`,
data: {
image: {
field,
constantValue: constantValue.image ?? {},
constantValueEnabled:
constantValueOverride.image ?? false,
},
},
styles: {
aspectRatio: imageStyle?.aspectRatio ?? "1.78",
width: imageStyle?.width ?? 640,
},
className:
"max-w-full sm:max-w-initial md:max-w-[450px] lg:max-w-none rounded-image-borderRadius w-full",
parentData: !constantValueOverride.image
? {
field,
image:
resolvedPromo?.image &&
!("video" in resolvedPromo.image)
? resolvedPromo.image
: {
url: "https://placehold.co/640x360",
height: 360,
width: 640,
},
}
: undefined,
sizes: {
base: "calc(100vw - 32px)",
md: "min(width, 450px)",
lg: "width",
},
} satisfies WithId<ImageWrapperProps>,
} satisfies WithId<VideoProps>,
},
],
ImageSlot: [
{
type: "ImageSlot",
props: {
id: `${props.id}-ImageSlot`,
data: {
image: {
field: isVideo ? "" : field,
constantValue: isVideo ? {} : (constantValue.image ?? {}),
constantValueEnabled: constantValueOverride.image ?? false,
},
},
styles: {
aspectRatio: imageStyle?.aspectRatio ?? "1.78",
width: imageStyle?.width ?? 640,
},
],
className:
"max-w-full sm:max-w-initial md:max-w-[450px] lg:max-w-none rounded-image-borderRadius w-full",
parentData: !constantValueOverride.image
? {
field: isVideo ? "" : field,
image:
!isVideo &&
resolvedPromo?.image &&
!("video" in resolvedPromo.image)
? resolvedPromo.image
: {
url: "https://placehold.co/640x360",
height: 360,
width: 640,
},
}
: undefined,
sizes: {
base: "calc(100vw - 32px)",
md: "min(width, 450px)",
lg: "width",
},
} satisfies WithId<ImageWrapperProps>,
},
],
CTASlot: [
{
type: "CTASlot",
Expand Down
4 changes: 1 addition & 3 deletions packages/visual-editor/src/components/migrations/0036_testimonials_section_slots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ export const testimonialsSectionSlots: Migration = {
field: props.data.testimonials.field,
constantValueEnabled:
props.data.testimonials.constantValueEnabled,
constantValue: constantValueEnabled
? cards.map((c) => ({ id: c.props.id }))
: [],
constantValue: cards.map((c) => ({ id: c.props.id })),
},
slots: {
CardSlot: cards,
Expand Down