feat: slot-ify footer #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colton-demetriou
requested review from
asanehisa,
benlife5,
briantstephan and
mkilpatrick
benlife5
reviewed
Oct 28, 2025
packages/visual-editor/src/components/footer/FooterExpandedLinksWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinkSectionSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinkSectionSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinksWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinksWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterLogoSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterUtilityImagesSlot.tsx
Outdated
Show resolved
Hide resolved
.../visual-editor/src/components/testing/screenshots/ExpandedFooter/[desktop] default props.png
Show resolved
Hide resolved
.../src/components/testing/screenshots/ExpandedFooter/[desktop] version 10 props - expanded.png
Show resolved
Hide resolved
...r/src/components/testing/screenshots/ExpandedFooter/[tablet] version 20 props - expanded.png
Show resolved
Hide resolved
asanehisa
reviewed
Oct 28, 2025
packages/visual-editor/src/components/categories/SlotsCategory.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Oct 28, 2025
.../visual-editor/src/components/testing/screenshots/ExpandedFooter/[desktop] default props.png
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterLinksSlot.tsx
Outdated
Show resolved
Hide resolved
This reverts commit d3a312f.
- Renamed footer migration from 0038 to 0039 - Updated test file to use version 39 - Resolved conflicts in locale files, SlotsCategory.tsx, and docs - Both expanded header and expanded footer slot migrations now included
asanehisa
reviewed
Oct 30, 2025
packages/visual-editor/src/components/footer/SecondaryFooterSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/ExpandedFooter.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinkSectionSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/FooterExpandedLinkSectionSlot.tsx
Outdated
Show resolved
Hide resolved
asanehisa
reviewed
Oct 30, 2025
packages/visual-editor/src/components/footer/CopyrightMessageSlot.tsx
Outdated
Show resolved
Hide resolved
asanehisa
reviewed
Oct 30, 2025
packages/visual-editor/src/components/footer/CopyrightMessageSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/CopyrightMessageSlot.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/ExpandedFooter.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Oct 30, 2025
benlife5
approved these changes
Oct 31, 2025
briantstephan
approved these changes
Oct 31, 2025
colton-demetriou
merged commit 57ac5d3
into
fall-2025-slot-ify-components
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.