feat: slot-ify team section #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colton-demetriou
commented
Oct 17, 2025
colton-demetriou
commented
colton-demetriou
requested review from
asanehisa,
benlife5,
briantstephan and
mkilpatrick
commit: |
asanehisa
reviewed
Oct 20, 2025
packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/TeamSection/TeamCard.tsx
Outdated
Show resolved
Hide resolved
...components/testing/screenshots/TeamSection/[desktop] version 0 props with constant value.png
Show resolved
Hide resolved
...mponents/testing/screenshots/TeamSection/[desktop] version 15 props with missing ctaType.png
Show resolved
Hide resolved
added 2 commits
October 20, 2025 12:42
asanehisa
reviewed
Oct 20, 2025
.../components/testing/screenshots/TeamSection/[desktop] version 0 props with entity values.png
Show resolved
Hide resolved
.../components/testing/screenshots/TeamSection/[desktop] version 0 props with entity values.png
Show resolved
Hide resolved
asanehisa
reviewed
Oct 20, 2025
...components/testing/screenshots/TeamSection/[desktop] version 7 props with constant value.png
Show resolved
Hide resolved
added 2 commits
October 20, 2025 13:26
...ots/TeamSection/[desktop] version 31 props with slot-based structure and constant values.png
Outdated
Show resolved
Hide resolved
asanehisa
reviewed
Oct 21, 2025
.../components/testing/screenshots/TeamSection/[desktop] version 0 props with entity values.png
Show resolved
Hide resolved
asanehisa
reviewed
Oct 21, 2025
.../components/testing/screenshots/TeamSection/[mobile] version 0 props with constant value.png
Show resolved
Hide resolved
asanehisa
reviewed
Oct 22, 2025
packages/visual-editor/src/components/pageSections/TeamSection/TeamSection.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Oct 22, 2025
packages/visual-editor/src/internal/puck/constant-value-fields/TeamSection.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/pageSections/TeamSection/TeamSection.tsx
Outdated
Show resolved
Hide resolved
benlife5
approved these changes
Oct 22, 2025
asanehisa
approved these changes
Oct 22, 2025
colton-demetriou
merged commit e685a18
into
fall-2025-slot-ify-components
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.