Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c422df4
add address slot
asanehisa Oct 1, 2025
314fd35
docs: auto-generate component documentation
github-actions[bot] Oct 1, 2025
be2f28b
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
bec3f2d
update gap
asanehisa Oct 1, 2025
6554951
update hasCoreInfo
asanehisa Oct 1, 2025
dfe8f3b
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
12ed569
adjust hasCoreInfo bool
asanehisa Oct 1, 2025
e4c4baa
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
40e30ca
adjust to usePuck
asanehisa Oct 1, 2025
7faf476
Merge branch 'address-slot' of https://github.com/yext/visual-editor …
asanehisa Oct 1, 2025
8901d5f
adjust again
asanehisa Oct 1, 2025
ffe7a1a
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
6c6e6ca
Merge branch 'fall-2025-slot-ify-components' into address-slot
asanehisa Oct 2, 2025
1968e28
use resolveData on live page
asanehisa Oct 2, 2025
7fe25d9
docs: auto-generate component documentation
github-actions[bot] Oct 2, 2025
75445d5
clean up
asanehisa Oct 2, 2025
3146ecf
clean
asanehisa Oct 2, 2025
804b553
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
80c22b9
add metadata to screenshot test
asanehisa Oct 2, 2025
84225eb
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
92908a5
add locale to document in test
asanehisa Oct 2, 2025
4e8e711
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
71f5b72
manually delete 3 screenshots
asanehisa Oct 2, 2025
f03f44c
add resolveAllData
asanehisa Oct 2, 2025
1a213bf
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
9b6f341
Merge branch 'fall-2025-slot-ify-components' into address-slot
asanehisa Oct 2, 2025
5bb162a
merge + adjust resolveAllData
asanehisa Oct 2, 2025
6d4277d
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
bc77098
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
5d4e23a
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
4ee6705
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
a702237
address comments
asanehisa Oct 2, 2025
730154b
Update component screenshots for visual-editor
github-actions[bot] Oct 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ import {
HeadingTextProps,
HeadingText,
} from "../contentBlocks/HeadingText.tsx";
import { Address, AddressProps } from "../contentBlocks/Address.tsx";
import { Video, VideoProps } from "../contentBlocks/Video.tsx";

export interface SlotsCategoryProps {
AddressSlot: AddressProps;
HeadingTextSlot: HeadingTextProps;
VideoSlot: VideoProps;
}
Expand All @@ -17,6 +19,7 @@ const lockedPermissions = {
};

export const SlotsCategoryComponents = {
AddressSlot: { ...Address, permissions: lockedPermissions },
HeadingTextSlot: { ...HeadingText, permissions: lockedPermissions },
VideoSlot: { ...Video, permissions: lockedPermissions },
};
Expand Down
81 changes: 42 additions & 39 deletions packages/visual-editor/src/components/contentBlocks/Address.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useTranslation } from "react-i18next";
import { ComponentConfig, Fields } from "@measured/puck";
import { ComponentConfig, Fields, PuckComponent } from "@measured/puck";
import {
AddressType,
getDirections,
Expand Down Expand Up @@ -72,53 +72,56 @@ const addressFields: Fields<AddressProps> = {
}),
};

const AddressComponent = ({ data, styles }: AddressProps) => {
const AddressComponent: PuckComponent<AddressProps> = (props) => {
const { data, styles, puck } = props;
const { t, i18n } = useTranslation();
const streamDocument = useDocument();
const address = resolveComponentData(
data.address,
i18n.language,
streamDocument
);
const coordinates = getDirections(
address as AddressType,
undefined,
undefined,
{ provider: "google" }
) as unknown as AddressType | undefined;
const coordinates = getDirections(address, undefined, undefined, {
provider: "google",
});

// Only show the address component if there's at least one line of the address
const showAddress = !!(
address?.line1 ||
address?.line2 ||
address?.city ||
address?.region ||
address?.postalCode
);

return (
<>
{address && (
<EntityField
displayName={pt("address", "Address")}
fieldId={data.address.field}
constantValueEnabled={data.address.constantValueEnabled}
>
<div className="flex flex-col gap-2 text-body-fontSize font-body-fontWeight font-body-fontFamily">
<RenderAddress
address={address}
lines={[
["line1"],
["line2"],
["city", ",", "region", "postalCode"],
]}
/>
</div>
{coordinates && styles.showGetDirectionsLink && (
<CTA
eventName={`getDirections`}
className="font-bold"
link={coordinates}
label={t("getDirections", "Get Directions")}
linkType="DRIVING_DIRECTIONS"
target="_blank"
variant={styles.ctaVariant}
/>
)}
</EntityField>
return showAddress ? (
<div className="flex flex-col gap-2 text-body-fontSize font-body-fontWeight font-body-fontFamily">
<EntityField
displayName={pt("address", "Address")}
fieldId={data.address.field}
constantValueEnabled={data.address.constantValueEnabled}
>
<RenderAddress
address={address}
lines={[["line1"], ["line2"], ["city", ",", "region", "postalCode"]]}
/>
</EntityField>
{coordinates && styles.showGetDirectionsLink && (
<CTA
eventName={`getDirections`}
className="font-bold"
link={coordinates}
label={t("getDirections", "Get Directions")}
linkType="DRIVING_DIRECTIONS"
target="_blank"
variant={styles.ctaVariant}
/>
)}
</>
</div>
) : puck.isEditing ? (
<div className="min-h-[40px]"></div>
) : (
<></>
);
};

Expand Down
40 changes: 18 additions & 22 deletions packages/visual-editor/src/components/contentBlocks/HeadingText.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from "react";
import { ComponentConfig, Fields } from "@measured/puck";
import { ComponentConfig, Fields, PuckComponent } from "@measured/puck";
import {
useDocument,
EntityField,
Expand Down Expand Up @@ -29,10 +29,8 @@ export type HeadingTextProps = {
};
};

const HeadingTextWrapper = React.forwardRef<
HTMLHeadingElement,
HeadingTextProps
>(({ data, styles, ...headingProps }, ref) => {
const HeadingTextWrapper: PuckComponent<HeadingTextProps> = (props) => {
const { data, styles, puck } = props;
const streamDocument = useDocument();
const { i18n } = useTranslation();

Expand All @@ -50,24 +48,22 @@ const HeadingTextWrapper = React.forwardRef<
streamDocument
);

return (
resolvedHeadingText && (
<div className={`flex ${justifyClass}`}>
<EntityField
displayName={pt("Heading", "Heading") + " " + styles.level}
fieldId={data.text.field}
constantValueEnabled={data.text.constantValueEnabled}
>
<Heading ref={ref} level={styles.level} {...headingProps}>
{resolvedHeadingText}
</Heading>
</EntityField>
</div>
)
return resolvedHeadingText ? (
<div className={`flex ${justifyClass}`}>
<EntityField
displayName={pt("Heading", "Heading") + " " + styles.level}
fieldId={data.text.field}
constantValueEnabled={data.text.constantValueEnabled}
>
<Heading level={styles.level}>{resolvedHeadingText}</Heading>
</EntityField>
</div>
) : puck.isEditing ? (
<div className="h-[30px]" />
) : (
<></>
);
});

HeadingTextWrapper.displayName = "HeadingText";
};

const headingTextFields: Fields<HeadingTextProps> = {
data: {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
import { Migration } from "@yext/visual-editor";

export const coreInfoSectionSlots: Migration = {
CoreInfoSection: {
action: "updated",
propTransformation: (props) => {
const infoHeadingText = props.data.info.headingText ?? {
constantValue: {
en: "Information",
hasLocalizedValue: "true",
},
constantValueEnabled: true,
field: "",
};
const hoursHeadingText = props.data.hours.headingText ?? {
constantValue: {
en: "Hours",
hasLocalizedValue: "true",
},
constantValueEnabled: true,
field: "",
};
const servicesHeadingText = props.data.services.headingText ?? {
constantValue: {
en: "Services",
hasLocalizedValue: "true",
},
constantValueEnabled: true,
field: "",
};
const headingLevel = props.styles.heading?.level ?? 3;
const headingAlign = props.styles.heading?.align ?? "left";

const address = props.data.info.address ?? {
constantValue: {
line1: "",
city: "",
postalCode: "",
countryCode: "",
},
field: "address",
};
const addressStyles = {
showGetDirectionsLink: props.styles.info.showGetDirectionsLink ?? true,
ctaVariant: props.styles.info.ctaVariant,
};

// Clean up old props
delete props.data.info.headingText;
delete props.data.hours.headingText;
delete props.data.services.headingText;
delete props.data.info.address;
delete props.styles.heading;
delete props.styles.info.showGetDirectionsLink;
delete props.styles.info.ctaVariant;

return {
...props,
slots: {
CoreInfoHeadingSlot: [
{
type: "HeadingTextSlot",
props: {
data: {
text: infoHeadingText,
},
styles: {
level: headingLevel,
align: headingAlign,
},
},
},
],
CoreInfoAddressSlot: [
{
type: "AddressSlot",
props: {
data: {
address: address,
},
styles: {
...addressStyles,
},
},
},
],
HoursHeadingSlot: [
{
type: "HeadingTextSlot",
props: {
data: {
text: hoursHeadingText,
},
styles: {
level: headingLevel,
align: headingAlign,
},
},
},
],
ServicesHeadingSlot: [
{
type: "HeadingTextSlot",
props: {
data: {
text: servicesHeadingText,
},
styles: {
level: headingLevel,
align: headingAlign,
},
},
},
],
},
};
},
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { updateFooterForAssetImages } from "./0020_footer_asset_images.ts";
import { setOpenNowDefault } from "./0021_set_open_now_default.ts";
import { organizeHeadingTextProps } from "./0022_organize_heading_text_props.ts";
import { eventSectionSlots } from "./0023_event_section_slots.ts";
import { coreInfoSectionSlots } from "./0024_core_info_section_slots.ts";
import { videoSectionSlots } from "./0025_video_section_slots.ts";

// To add a migration:
Expand Down Expand Up @@ -53,6 +54,6 @@ export const migrationRegistry: MigrationRegistry = [
setOpenNowDefault,
organizeHeadingTextProps,
eventSectionSlots,
{}, // address migration placeholder
coreInfoSectionSlots,
videoSectionSlots,
];
Loading
Loading