Skip to content

fix: fonts not loading in editor #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colton-demetriou merged 6 commits into from
Oct 1, 2025
Merged

fix: fonts not loading in editor #793

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99e53c4
testing
Oct 1, 2025
5673bac
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
48fa8fb
Update component screenshots for visual-editor
github-actions[bot] Oct 1, 2025
04e611b
fix
Oct 1, 2025
f56d42e
rm comment
Oct 1, 2025
c34994b
clean up
Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/visual-editor/src/utils/applyTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,18 +135,53 @@ const generateContrastingColors = (themeData: ThemeData) => {
return contrastingColors;
};

// Helper function to update font links in a document
const updateFontLinksInDocument = (
document: Document,
fontLinkTags: string
) => {
const existingLinks = document.querySelectorAll(
'link[href*="fonts.googleapis.com"]'
Copy link
Collaborator

@mkilpatrick mkilpatrick Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when the custom fonts project happens? This won't be the hosted url.

);
existingLinks.forEach((link) => link.remove());

if (fontLinkTags) {
const tempDiv = document.createElement("div");
tempDiv.innerHTML = fontLinkTags;
const links = tempDiv.querySelectorAll("link");
links.forEach((link) => {
document.head.appendChild(link);
});
}
};

export const updateThemeInEditor = async (
newTheme: ThemeData,
themeConfig: ThemeConfig
) => {
devLogger.logFunc("updateThemeInEditor");

const defaultThemeValues = generateCssVariablesFromThemeConfig(themeConfig);
const mergedThemeData = { ...defaultThemeValues, ...newTheme };
const inUseFonts = extractInUseFontFamilies(mergedThemeData, defaultFonts);

let fontLinkTags: string;
if (Object.keys(inUseFonts).length === 0) {
fontLinkTags = constructGoogleFontLinkTags({
"Open Sans": defaultFonts["Open Sans"],
});
} else {
fontLinkTags = constructGoogleFontLinkTags(inUseFonts);
}

const newThemeTag = internalApplyTheme(newTheme, themeConfig);
const editorStyleTag = window.document.getElementById(THEME_STYLE_TAG_ID);
if (editorStyleTag) {
editorStyleTag.innerText = newThemeTag;
}

updateFontLinksInDocument(window.document, fontLinkTags);

const observer = new MutationObserver(() => {
const iframe = document.getElementById(
PUCK_PREVIEW_IFRAME_ID
Expand All @@ -156,6 +191,7 @@ export const updateThemeInEditor = async (
if (pagePreviewStyleTag) {
observer.disconnect();
pagePreviewStyleTag.innerText = newThemeTag;
updateFontLinksInDocument(iframe.contentDocument!, fontLinkTags);
}
});

Expand Down
Loading