feat: add heading text slot #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlife5
commented
Sep 29, 2025
Contributor
Author
|
At the risk of merge conflicts, I'm thinking we may want to have a separate branch for these changes in case we want/need to push out other fixes before the whole set of slot changes is ready |
asanehisa
reviewed
Sep 29, 2025
benlife5
commented
Sep 29, 2025
...c/components/testing/screenshots/EventSection/[desktop] default props with document data.png
Show resolved
Hide resolved
Contributor
agree. then it's easier to ship smaller bits at a time too so multiple people can work on slots. How's https://github.com/yext/visual-editor/tree/fall-2025-slot-ify-components |
benlife5
changed the base branch from
main
to
fall-2025-slot-ify-components
benlife5
requested review from
briantstephan,
colton-demetriou and
mkilpatrick
asanehisa
approved these changes
Sep 29, 2025
colton-demetriou
approved these changes
Sep 29, 2025
mkilpatrick
approved these changes
Sep 29, 2025
benlife5
merged commit 7a67734
into
fall-2025-slot-ify-components
26 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EventSection to use a slot component for the section heading text. Refactors HeadingText to include an align prop and organize props into data/styles
Will update the rest of EventSection (+tests) in separate PR but heading will be a shared component
Used a SlotsCategory because it seems like
resolvePermissionsdoesn't support checking if the component is in a slot or not. Will start a thread with the Puck team because that would be easier.Screen.Recording.2025-09-29.at.1.52.10.PM.mov