Skip to content

Conversation

@benlife5
Copy link
Contributor

Follow up to #985

Also removes some unused packages and code

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Walkthrough

This PR removes several dev/runtime dependencies (ts-node, react-aria-components, zod) from root and packages/visual-editor package.json files, prunes THIRD-PARTY-NOTICES, deletes many historical component tests across multiple sections, removes exported test helpers and messaging/CTA utilities (testSite, useSendMessageToIFrame, translatableCTAFields, LINK_ONLY_CTA_CONFIG, ctaTypeToEntityFieldType), updates docs, and removes the components npm script from the starter package.

Sequence Diagram(s)

(omitted)

Possibly related PRs

Suggested labels

create-dev-release

Suggested reviewers

  • mkilpatrick
  • briantstephan
  • colton-demetriou
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: update screenshots batch 2' is partially related to the changeset. While the PR does include screenshot updates (HeroSection.test.tsx docs reference change), the primary changes involve removing dependencies and test cases across multiple files, which goes well beyond just updating screenshots. Consider using a more comprehensive title that reflects the broader scope, such as 'chore: cleanup test fixtures and remove unused dependencies' or 'chore: remove legacy test versions and dependencies'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description mentions it is a follow-up to #985 and notes 'removes some unused packages and code', which aligns with the actual changes in the PR that include dependency removals and test case cleanup.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cleanup-screenshots-2

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@packages/visual-editor/src/components/pageSections/PhotoGallerySection/PhotoGallerySection.test.tsx`:
- Around line 732-733: Remove the dead empty conditional checking for the old
test name by deleting the `if (name === "version 53 gallery variant with 3
images") { }` block in PhotoGallerySection.test.tsx; this condition is stale
because the test was renamed to `"version 53 gallery variant with mixed locale
images"`, so simply remove the empty `if` (referencing the `name` variable and
that exact string) to clean up dead code.
🧹 Nitpick comments (1)
packages/visual-editor/src/internal/hooks/useMessage.ts (1)

282-285: Stale JSDoc reference to "iframe".

Now that useSendMessageToIFrame has been removed, the comment on Line 284 still mentions "from the parent window or iframe." Consider updating it to just "from the parent window."

✏️ Suggested fix
 /**
  * Sets a status based on the incoming message's status.
  * `@param` setStatus - A React useState hook for setting the status of the
- * original postMessage coming from the parent window or iframe.
+ * original postMessage coming from the parent window.
  */

"dev:stackblitz": "pages dev --local --no-prod-url --noInit",
"prod": "pages prod",
"build": "pages build",
"components": "REGISTRY_URL=https://reliably-numerous-kit.pgsdemo.com/components npx shadcn add"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not using the registry anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we ripped it out since it hadn't been updating in a long time and no one was using it

Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants