-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update screenshots batch 2 #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
WalkthroughThis PR removes several dev/runtime dependencies (ts-node, react-aria-components, zod) from root and packages/visual-editor package.json files, prunes THIRD-PARTY-NOTICES, deletes many historical component tests across multiple sections, removes exported test helpers and messaging/CTA utilities (testSite, useSendMessageToIFrame, translatableCTAFields, LINK_ONLY_CTA_CONFIG, ctaTypeToEntityFieldType), updates docs, and removes the Sequence Diagram(s)(omitted) Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@packages/visual-editor/src/components/pageSections/PhotoGallerySection/PhotoGallerySection.test.tsx`:
- Around line 732-733: Remove the dead empty conditional checking for the old
test name by deleting the `if (name === "version 53 gallery variant with 3
images") { }` block in PhotoGallerySection.test.tsx; this condition is stale
because the test was renamed to `"version 53 gallery variant with mixed locale
images"`, so simply remove the empty `if` (referencing the `name` variable and
that exact string) to clean up dead code.
🧹 Nitpick comments (1)
packages/visual-editor/src/internal/hooks/useMessage.ts (1)
282-285: Stale JSDoc reference to "iframe".Now that
useSendMessageToIFramehas been removed, the comment on Line 284 still mentions "from the parent window or iframe." Consider updating it to just "from the parent window."✏️ Suggested fix
/** * Sets a status based on the incoming message's status. * `@param` setStatus - A React useState hook for setting the status of the - * original postMessage coming from the parent window or iframe. + * original postMessage coming from the parent window. */
...s/visual-editor/src/components/pageSections/PhotoGallerySection/PhotoGallerySection.test.tsx
Outdated
Show resolved
Hide resolved
| "dev:stackblitz": "pages dev --local --no-prod-url --noInit", | ||
| "prod": "pages prod", | ||
| "build": "pages build", | ||
| "components": "REGISTRY_URL=https://reliably-numerous-kit.pgsdemo.com/components npx shadcn add" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not using the registry anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we ripped it out since it hadn't been updating in a long time and no one was using it
jwartofsky-yext
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Follow up to #985
Also removes some unused packages and code