feat: add debounce logic to autocomplete and filter search #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 92.07173194903257% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds debouncing to the autocomplete and filter search calls. Currently, this is set to 200ms. This means that we will not fire autocomplete or filter search requests until 200ms has elapsed since the last keystroke, in order to save on unnecessary queries while the user is still actively typing. This number was chosen based on the average typing speed being roughly 4-5 characters per second.
The relevant tests were modified by adding intentional pauses during execution of some tests, in order to allow the debouncing logic to have time to execute
J=WAT-4708