Skip to content

Add optional ariaLabel prop to FilterSearch to set aria-label on input #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Add optional ariaLabel prop to FilterSearch to set aria-label on input #495

merged 2 commits into from
Mar 25, 2025

Conversation

tpotla
Copy link
Contributor

@tpotla tpotla commented Mar 25, 2025

No description provided.

@tpotla tpotla requested a review from a team as a code owner March 25, 2025 16:01
@github-actions GitHub Actions
Copy link
Contributor

Current unit coverage is 92.06273764258555%
Current visual coverage is 79.04245709123758%
Current combined coverage is 92.541567695962%

@coveralls
Copy link

coveralls commented Mar 25, 2025 •
edited
Loading

Coverage Status

coverage: 85.189%. remained the same
when pulling 8f2f474 on dev/filtersearch-wcag-fix
into 5955aef on main.

k-gerner
k-gerner approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@k-gerner k-gerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@k-gerner k-gerner merged commit b47f3f4 into main Mar 25, 2025
21 of 22 checks passed
@k-gerner k-gerner deleted the dev/filtersearch-wcag-fix branch March 25, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-gerner k-gerner k-gerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpotla @coveralls @k-gerner