Remove Node 12 deprecation warnings #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 88.8646288209607% |
oshi97
approved these changes
Dec 6, 2022
nmanu1
added a commit
to yext/react-components
that referenced
this pull request
Dec 6, 2022
Update the `sync-sites-branch` GH workflow to remove Node 12 deprecation [warnings](https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). These are the same changes as in the `search-ui-react` [PR](yext/search-ui-react#345) since this workflow is just copied from there. I made an [item](https://yexttest.atlassian.net/browse/SLAP-2507) to move this workflow into the reusable workflows repo so that multiple updates aren't needed for any other changes in the future. J=SLAP-2468 TEST=manual See the PR linked above for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
sync-sites-branchGH workflow to remove Node 12 deprecation warnings caused bymtanzi/action-automergeand an older version ofactions/checkout. Sincemtanzi/action-automergehas not been updated in a couple years, I replaced it withdevmasx/merge-branch, which seems to be more actively maintained, is more widely used in the GH Marketplace, and doesn't produce warnings.J=SLAP-2468
TEST=manual
Test on a forked repo and see that the workflow doesn't have any warnings. The default branch of the repo is successfully synced with a test branch with a merge commit titled
Merge <default-branch> into <target-branch>.