Skip to content

Create hot-fix v1.0.1. #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Create hot-fix v1.0.1. #318

merged 1 commit into from
Oct 18, 2022

Conversation

tmeyer2115
Copy link
Collaborator

@tmeyer2115 tmeyer2115 commented Oct 18, 2022

This hot-fix resolves #294. We had lodash as a devDependency, even though it's used in src. I also updated the import of isEqual in filterutils.tsx to follow best practices.

J=SLAP-2404
TEST=none

This hotfix fixes issue #294. We had `lodash` as a devDependency, even
though it's used in src.
@tmeyer2115 tmeyer2115 requested a review from a team as a code owner October 18, 2022 14:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.454% when pulling ea571cf on hotfix/v1.0.1 into 7a139fb on main.

@github-actions
Copy link
Contributor

Current unit coverage is 88.5823754789272%
Current visual coverage is 77.43315508021391%
Current combined coverage is 89.11877394636015%

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can the PR description be updated to use one of the keywords to automatically close the GH issue?

@tmeyer2115
Copy link
Collaborator Author

nit: can the PR description be updated to use one of the keywords to automatically close the GH issue?

Done!

@tmeyer2115 tmeyer2115 requested a review from nmanu1 October 18, 2022 16:08
@tmeyer2115 tmeyer2115 merged commit 64ea8d7 into main Oct 18, 2022
tatimblin pushed a commit that referenced this pull request Nov 3, 2022
This hot-fix resolves #294. We had `lodash` as a devDependency, even though it's used in `src`. I also updated the import of `isEqual` in `filterutils.tsx` to follow best practices.

J=SLAP-2404
TEST=none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lodash/isEqual is not listed as a dependency
3 participants