Fix TS errors in `tests` directory #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nmanu1 merged 4 commits into develop from dev/tests-ts-errors

Oct 13, 2022

Contributor

nmanu1 commented Oct 12, 2022

Fix all TS errors in the tests folder.

J=SLAP-2360
TEST=manual

Go through all files in tests and see that there are no more errors.

nmanu1 and others added 2 commits

October 12, 2022 12:32


          Fix TS errors in tests directory

6427d50


          Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

041ea1d

…y notices check

coveralls commented Oct 12, 2022 •

edited

Loading

Coverage remained the same at 85.356% when pulling b85994f on dev/tests-ts-errors into 776086a on develop.

Contributor

github-actions bot commented Oct 12, 2022

Current unit coverage is 88.49693251533742%
Current visual coverage is 77.40899357601712%
Current combined coverage is 89.03374233128834%

nmanu1 marked this pull request as ready for review

October 12, 2022 16:39

nmanu1 requested a review from a team as a code owner

October 12, 2022 16:39

yen-tt reviewed

View reviewed changes

tests/components/AppliedFilters.test.tsx Outdated Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/components/LocationBias.test.tsx Outdated Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/__utils__/mocks.ts Outdated Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/components/RangeInput.stories.tsx Outdated Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/components/UniversalResults.stories.tsx Outdated Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/components/UniversalResults.test.tsx Outdated Show resolved Hide resolved

nmanu1 added 2 commits

October 12, 2022 14:48


          Feedback

faccf66


          Update RecursivePartial

b85994f

nmanu1 requested a review from yen-tt

October 12, 2022 23:08

tmeyer2115 reviewed

View reviewed changes

tests/__fixtures__/core/search-service.ts Show resolved Hide resolved

tests/__utils__/mocks.ts Show resolved Hide resolved

yen-tt reviewed

View reviewed changes

tests/__fixtures__/core/search-service.ts Show resolved Hide resolved

tests/components/SpellCheck.test.tsx Show resolved Hide resolved

nmanu1 requested a review from yen-tt

October 13, 2022 14:37

yen-tt approved these changes

View reviewed changes

nmanu1 merged commit d8e76b9 into develop

nmanu1 deleted the dev/tests-ts-errors branch

October 13, 2022 21:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet