Skip to content

Run tests on react v18 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

Run tests on react v18 #310

merged 1 commit into from
Oct 3, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Sep 30, 2022 •
edited
Loading

Update the run-tests workflow to have tests run on v18 of react, as well as v17 and v16.4 as it currently does.

J=SLAP-2125
TEST=manual

See that the tests workflow runs on react 16.14, 17, and 18 on this PR.

@nmanu1 nmanu1 requested a review from a team as a code owner September 30, 2022 19:55
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.356% when pulling 0484433 on dev/test-react-18 into ae97885 on develop.

@github-actions
Copy link
Contributor

Current unit coverage is 88.49693251533742%
Current visual coverage is 77.40899357601712%
Current combined coverage is 89.03374233128834%

@nmanu1 nmanu1 merged commit 776086a into develop Oct 3, 2022
@nmanu1 nmanu1 deleted the dev/test-react-18 branch October 3, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yen-tt yen-tt yen-tt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmanu1 @coveralls @yen-tt