wrap DropdownItem itemData usages with useMemo #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates DropdownItem itemData usages to be wrapped inside a useMemo. Originally, I tried refactoring Dropdown to not use itemData, since itemData feels a bit like an anti pattern, however this proved to be very difficult. I also tried wrapping DropdownItem usages inside a parent component, like FilterSearchDropdownItem, however recursivelyMapChildren does not work for wrapper components that internally use DropdownItem. It only works when DropdownItem is specified as a direct child. So, as a workaround, I wrapped itemData usages inside useMemo by creating a 2d matrix of item datas, itemDataMatrix, which is then referenced by component usages. J=SLAP-2016 TEST=manual see that autocomplete options appear and can be selected see that filtersearch results appear and can be selected and applied to the search
yen-tt
reviewed
Apr 14, 2022
yen-tt
approved these changes
Apr 14, 2022
yen-tt
pushed a commit
that referenced
this pull request
Sep 28, 2022
This commit updates DropdownItem itemData usages to be wrapped inside a useMemo. Originally, I tried refactoring Dropdown to not use itemData, since itemData feels a bit like an anti pattern, however this proved to be very difficult. I also tried wrapping DropdownItem usages inside a parent component, like FilterSearchDropdownItem, however recursivelyMapChildren does not work for wrapper components that internally use DropdownItem. It only works when DropdownItem is specified as a direct child. So, as a workaround, I wrapped itemData usages inside useMemo by creating a 2d matrix of item datas, itemDataMatrix, which is then referenced by component usages. J=SLAP-2016 TEST=manual see that autocomplete options appear and can be selected see that filtersearch results appear and can be selected and applied to the search resolved all eslint warnings. yay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates DropdownItem itemData usages to be wrapped inside a useMemo.
Originally, I tried refactoring Dropdown to not use itemData, since itemData feels
a bit like an anti pattern, however this proved to be very difficult.
I also tried wrapping DropdownItem usages inside a parent component, like
FilterSearchDropdownItem, however recursivelyMapChildren does not work
for wrapper components that internally use DropdownItem. It only works
when DropdownItem is specified as a direct child.
So, as a workaround, I wrapped itemData usages inside useMemo by creating
a 2d matrix of item datas, itemDataMatrix, which is then referenced by component
usages.
J=SLAP-2016
TEST=manual
see that autocomplete options appear and can be selected
see that filtersearch results appear and can be selected and applied to the search
resolved all eslint warnings. yay!